1007290 - Remove text type code from ToolbarEditText

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

"Text type"-related code in ToolbarEditText were used for changing the go button. Now that button is gone, we don't need the text type code either.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Remove text type code from ToolbarEditText (v1)

Simple removal of unused code related to the go button.

Try: https://tbpl.mozilla.org/?tree=Try&rev=e547d6899a40

Comment 2

[Lucas Rocha (:lucasr)]

Comment on attachment 8423271 [details] [diff] [review]
Remove text type code from ToolbarEditText (v1)

Review of attachment 8423271 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine but I thought we were using this code to set the keyboard's 'go' button state to search/go/etc? Have we removed this feature? Why?

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

(In reply to Lucas Rocha (:lucasr) from comment #2)
> Comment on attachment 8423271 [details] [diff] [review]
> Remove text type code from ToolbarEditText (v1)
> 
> Review of attachment 8423271 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks fine but I thought we were using this code to set the keyboard's 'go'
> button state to search/go/etc? Have we removed this feature? Why?

Yes, we removed it recently in bug 998398 (also see bug 1007698 comment 3). In short it tended to break different keyboards, and the benefit was too small.

Try: https://tbpl.mozilla.org/?tree=Try&rev=e547d6899a40

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/2b5762bd1d57

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2b5762bd1d57