Closed Bug 1007290 Opened 8 years ago Closed 8 years ago

Remove text type code from ToolbarEditText

Categories

(Firefox for Android Graveyard :: Awesomescreen, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 32

People

(Reporter: jchen, Assigned: jchen)

References

Details

Attachments

(1 file)

"Text type"-related code in ToolbarEditText were used for changing the go button. Now that button is gone, we don't need the text type code either.
Simple removal of unused code related to the go button.

Try: https://tbpl.mozilla.org/?tree=Try&rev=e547d6899a40
Attachment #8423271 - Flags: review?(lucasr.at.mozilla)
Comment on attachment 8423271 [details] [diff] [review]
Remove text type code from ToolbarEditText (v1)

Review of attachment 8423271 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine but I thought we were using this code to set the keyboard's 'go' button state to search/go/etc? Have we removed this feature? Why?
Attachment #8423271 - Flags: review?(lucasr.at.mozilla) → review+
(In reply to Lucas Rocha (:lucasr) from comment #2)
> Comment on attachment 8423271 [details] [diff] [review]
> Remove text type code from ToolbarEditText (v1)
> 
> Review of attachment 8423271 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks fine but I thought we were using this code to set the keyboard's 'go'
> button state to search/go/etc? Have we removed this feature? Why?

Yes, we removed it recently in bug 998398 (also see bug 1007698 comment 3). In short it tended to break different keyboards, and the benefit was too small.

Try: https://tbpl.mozilla.org/?tree=Try&rev=e547d6899a40
Assignee: nobody → nchen
Status: NEW → ASSIGNED
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2b5762bd1d57
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 32
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.