Closed Bug 1007352 Opened 6 years ago Closed 6 years ago

Marionette apps needs to use proper homescreen origin

Categories

(Testing Graveyard :: JSMarionette, defect)

x86
macOS
defect
Not set

Tracking

(b2g-v2.0 fixed)

RESOLVED FIXED
2.0 S3 (6june)
Tracking Status
b2g-v2.0 --- fixed

People

(Reporter: kgrandon, Assigned: jlal)

References

Details

(Whiteboard: [p=2],[systemsfe])

Attachments

(2 files)

Every time you leave a TODO in your code a kitten dies.

https://github.com/mozilla-b2g/marionette-apps/blob/master/lib/launch.js#L10
Attached file Github pull request
Hi Kevin,
I think we might not need to wait for homescreen app anymore after http://bugzil.la/999574 is fixed, right?

We are fixing a related issue for marionette-apps module at Bug 1003788.
You could take a look for that.
I don't think that's entirely true as bug 999574 only fixes the --runapp command. I am pretty sure this is still an issue. I will take a look at bug 1003788. Thanks!
Depends on: 1003788
Got it, Kevin.
Stealing this in my work queue...
Assignee: kgrandon → jlal
Thanks for stealing :) How many beers (or diapers) would it take to bribe you to fix this in the next week or two?
Flags: needinfo?(jlal)
Back from PTO... I am planning to work on this Wednesday... I will flag you for r?
Flags: needinfo?(jlal)
Target Milestone: 2.0 S1 (9may) → 2.0 S2 (23may)
One or both of you review please :)
Attachment #8428967 - Flags: review?(kgrandon)
Attachment #8428967 - Flags: review?(evanxd)
Comment on attachment 8428967 [details] [review]
https://github.com/mozilla-b2g/marionette-apps/pull/32

I applied the patch locally and everything seems to work. Nice!
Attachment #8428967 - Flags: review?(kgrandon) → review+
Target Milestone: 2.0 S2 (23may) → 2.0 S3 (6june)
I published a marionette-apps@0.3.4-alpha version which contains the homescreen origin changes, but without the latest breaking 0.3.5 changes.
And landed in master: https://github.com/mozilla-b2g/gaia/commit/a76bb8dea7e12a47ebd65ab6e96a23b0fa59fbf8
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Mass modify - set status-b2g-v2.0 fixed for fixed bugs under vertical homescreen dependency tree.
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.