Closed
Bug 1007352
Opened 11 years ago
Closed 11 years ago
Marionette apps needs to use proper homescreen origin
Categories
(Testing Graveyard :: JSMarionette, defect)
Tracking
(b2g-v2.0 fixed)
RESOLVED
FIXED
2.0 S3 (6june)
| Tracking | Status | |
|---|---|---|
| b2g-v2.0 | --- | fixed |
People
(Reporter: kgrandon, Assigned: jlal)
References
Details
(Whiteboard: [p=2],[systemsfe])
Attachments
(2 files)
Every time you leave a TODO in your code a kitten dies.
https://github.com/mozilla-b2g/marionette-apps/blob/master/lib/launch.js#L10
|
Reporter | |
Comment 1•11 years ago
|
||
|
||
Comment 2•11 years ago
|
||
Hi Kevin,
I think we might not need to wait for homescreen app anymore after http://bugzil.la/999574 is fixed, right?
We are fixing a related issue for marionette-apps module at Bug 1003788.
You could take a look for that.
|
|
Reporter | |
Comment 3•11 years ago
|
||
I don't think that's entirely true as bug 999574 only fixes the --runapp command. I am pretty sure this is still an issue. I will take a look at bug 1003788. Thanks!
|
|
||
Comment 4•11 years ago
|
||
Got it, Kevin.
|
|
Reporter | |
Comment 6•11 years ago
|
||
Thanks for stealing :) How many beers (or diapers) would it take to bribe you to fix this in the next week or two?
Flags: needinfo?(jlal)
|
Assignee | |
Comment 7•11 years ago
|
||
Back from PTO... I am planning to work on this Wednesday... I will flag you for r?
Flags: needinfo?(jlal)
|
||
Updated•11 years ago
|
Target Milestone: 2.0 S1 (9may) → 2.0 S2 (23may)
|
|
Assignee | |
Comment 8•11 years ago
|
||
One or both of you review please :)
Attachment #8428967 -
Flags: review?(kgrandon)
Attachment #8428967 -
Flags: review?(evanxd)
|
|
Reporter | |
Comment 9•11 years ago
|
||
Comment on attachment 8428967 [details] [review]
https://github.com/mozilla-b2g/marionette-apps/pull/32
I applied the patch locally and everything seems to work. Nice!
Attachment #8428967 -
Flags: review?(kgrandon) → review+
|
||
Updated•11 years ago
|
Target Milestone: 2.0 S2 (23may) → 2.0 S3 (6june)
|
|
Reporter | |
Comment 10•11 years ago
|
||
|
|
Reporter | |
Comment 11•11 years ago
|
||
I published a marionette-apps@0.3.4-alpha version which contains the homescreen origin changes, but without the latest breaking 0.3.5 changes.
|
|
Reporter | |
Comment 12•11 years ago
|
||
In gaia-node-modules: https://github.com/mozilla-b2g/gaia-node-modules/commit/a56c1dc6c47e549cff991900966672980875779b
Pull request to gaia is here: https://github.com/mozilla-b2g/gaia/pull/19737
|
|
Reporter | |
Comment 13•11 years ago
|
||
And landed in master: https://github.com/mozilla-b2g/gaia/commit/a76bb8dea7e12a47ebd65ab6e96a23b0fa59fbf8
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
||
Comment 14•11 years ago
|
||
Comment on attachment 8428967 [details] [review]
https://github.com/mozilla-b2g/marionette-apps/pull/32
Thanks for Kevin's review.
Attachment #8428967 -
Flags: review?(evanxd)
|
|
Reporter | |
Comment 15•11 years ago
|
||
Mass modify - set status-b2g-v2.0 fixed for fixed bugs under vertical homescreen dependency tree.
status-b2g-v2.0:
--- → fixed
|
||
Updated•7 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•