1007374 - Showing negative value in dimensions for element with display:none

Status: RESOLVED FIXED

(DevTools :: Inspector: Layout, defect, P2)

Description

[Brian Grinstead [:bgrins]]

Go to: http://www.nerdist.com/podcasts-landing/.
Open devtools, and inspect this element: $$("#div-gpt-ad-300x250-tablet-grid")

Box model dimensions are showing 0x-27 or 0x-26 depending on the system.  See gif at: https://twitter.com/jonathansampson/status/464137697800781824

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Brian, the URL from comment 0 doesn't exist anymore, it redirects to the homepage.
I tried to search the node you indicated with no luck though.
I couldn't find any bug ( opened or closed ) with similar problem.
I doubt you remember what was the cause of this issue, but does it rings a bell ?

Comment 2

[Brian Grinstead [:bgrins]]

I am seeing one case of this still at: https://web.archive.org/web/20140509231150/http://www.nerdist.com/podcasts-landing if you select this element in the inspector: #div-gpt-ad-300x250-tablet-grid (which appears to be hidden and should be 0x0 but instead shows up as 0x-26.984)

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: negative.html

Simpler STR :

1. Open attachment
2 [review]. Open Inspector
3. Select <div class="negative"> node
4. Open "Box Model" tab

Expected Result:
content box shows 0x0 (because div is "display:none;")

Actual Result:
content box shows -20x-20

Note that similar issue can be triggered with the "border" style applied on a none-displayed element.

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

When the element isn't displayed, we could avoid showing any content size.
For what it's worth, Chrome is showing auto x auto

Comment 5

[Karan Yadav]

I have successfully reproduced this bug. Can this be assigned to me ?

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Karan Yadav from comment #5)

I have successfully reproduced this bug. Can this be assigned to me ?

Sure, I just assigned it to you

Comment 7

[Karan Yadav]

Attachment: Bug 1007374 - Show "auto" in box-model if width or height is less than 0. r=#devtools-reviewers

Comment 8

[Karan Yadav]

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #4)

When the element isn't displayed, we could avoid showing any content size.
For what it's worth, Chrome is showing auto x auto

I have implemented the patch based on this suggestion. Please review it and let me know if there are any concerns or improvements needed.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec29bce06ae0
Show "auto" in box-model if width or height is less than 0. r=devtools-reviewers,nchevobbe

Comment 10

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/ec29bce06ae0