1007379 - adu-by-signature should show records with crash_count of 0

Status: RESOLVED FIXED

(Socorro :: Database, task)

Description

[Robert Helmer [:rhelmer]]

Pretty sure we're just filtering these out now, but bsmedberg mentioned in IRC:

14:42 <@bsmedberg> rhelmer: there isn't any record for 2014-05-06. This may be 
                   because there weren't any crashes on the 2014-05-06 nightly 
                   (we fixed this on the 5th)
14:43 <@bsmedberg> but I'd still expect to see a record there with a 
                   crash_count of 0

Comment 1

[Robert Kaiser]

I still don't like showing each build as a default view and still would rpefer build days summed up, in which case we probably wouldn't have run into that, but for those things, Benjamin and me have clashed for years and it seems that we now get into the nice situation of having one here, one there and Socorro getting even more confusing - but I somehow feel like this is how we like it in this project.

Comment 2

[Robert Helmer [:rhelmer]]

Working on this in PR https://github.com/mozilla/socorro/pull/2052

Comment 3

[Robert Helmer [:rhelmer]]

(In reply to Robert Kaiser (:[e-mail]) from comment #1)
> I still don't like showing each build as a default view and still would
> rpefer build days summed up, in which case we probably wouldn't have run
> into that, but for those things, Benjamin and me have clashed for years and
> it seems that we now get into the nice situation of having one here, one
> there and Socorro getting even more confusing - but I somehow feel like this
> is how we like it in this project.

I don't know the history of this report, but it's available as JSON via the API if that is helpful at all.

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/baf8d38b102048bcc5ed17cdb077a1b2291eb74b
fix bug 1007379 - report build_adu with no crashes r=selenamarie

https://github.com/mozilla/socorro/commit/25f36656b84fcbf078d42705c364aaa8c3189683
Merge pull request #2052 from rhelmer/bug1007379-adu-by-sig-should-show-crashcount-of-0

Bug1007379 adu by sig should show crashcount of 0

Comment 5

[Robert Helmer [:rhelmer]]

Migration run in both stage and prod.

Comment 6

[Robert Helmer [:rhelmer]]

Per bug 1019653 comment 7, this does not appear to be working correctly - I'll take a look.

Comment 7

[Robert Helmer [:rhelmer]]

So I looked into it just now, and I did add a test for this case as part of this feature:

https://github.com/mozilla/socorro/blob/master/socorro/unittest/external/postgresql/test_crash_adu_by_build_signature.py#L212

Going to investigate the data here, could be testing the wrong thing.

Comment 8

[Robert Helmer [:rhelmer]]

Not currently working on this. Is it still happening or was it fixed?

Comment 9

[Peter Bengtsson [:peterbe]]

AduBySignature is deprecated 
https://crash-stats.mozilla.com/api/#AduBySignature since it's not used anywhere any more.