1007400 - Remove unused SSL code from netError.xhtml

Status: RESOLVED WONTFIX

(Firefox :: General, defect)

Description

[Valentin Tsatskin [:vt]]

Stemming from the work in bug 982347, we should remove the unused SSL code from netError.xhtml as it never gets executed. Work was started on this in attachment 8401039 [details] [diff] [review]. Please note that the attachment is not solely focused on removing dead SSL code, but was a general clean up. So not every change applies.

The main idea here is that we remove the following functions:
- showSecuritySection
- addDomainErrorLink
- endsWith

We also want to remove any code paths that deal with the nssBadCert error. Any xhtml elements used should also be removed, such as elements with the following ids:
- securityOverrideDiv
- et_nssFailure2
- et_nssBadCert
- ed_nssBadCert
- ed_nssFailure2

Comment 1

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Note: This may well be a WONTFIX. 

If the solution to bug 1007412 ends up being to consolidate all forks back into one base copy, with selective overrides for things like style and some additional JS, then that base copy needs to retain the SSL behaviour.  

By default, netError.xhtml *does* still handle SSL errors. We override that by setting the security.alternate_certificate_error_page preferences to "certerror", which makes docshell (?) instead use about:certerror for such errors. However, not all applications do this. So it's not exactly dead code.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

I think we should focus on bug 1007412/merging, and not pursue this.