1007408 - Throttle onrefresh calls in home panels

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[:Margaret Leibovic]

If a user does a pull-to-refresh action while the view is currently refreshing, we shouldn't let them trigger a second refresh.

Comment 1

[:Margaret Leibovic]

Attachment: Don't call refresh handler if view is already being refreshed

With this patch, we avoid sending a message to Java to call the view's onrefresh handler if the view is currently being refreshed.

In order to get this to work, I had to change the ordering of the logic in GeckoSwipeRefreshLayout#startRefresh. The only other GeckoSwipeRefreshLayout consumer in the tree is RemoteTabsContainer, and that won't be affected by this change. As much as I'm not a fan of modifying the source we took from Android's SwipeRefreshLayout.java, this seems like the easiest way to do what I want :)

Comment 2

[Lucas Rocha (:lucasr)]

Comment on attachment 8419068 [details] [diff] [review]
Don't call refresh handler if view is already being refreshed

Review of attachment 8419068 [details] [diff] [review]:
-----------------------------------------------------------------

Hmm... this patch changes the behaviour of the widget to something I'd consider a bit unexpected. Isn't this something add-ons should handle themselves anyway? Not only for pull-to-refresh but any case where they end up with overlapping refresh calls. I'd prefer a solution that doesn't involve changing the widget. So, if we really want to handle this in the UI, maybe just post a runnable on the UI thread and check the refreshing state there?

Comment 3

[:Margaret Leibovic]

Thinking about this a bit more, I'm starting to agree this is something that add-ons could just handle themselves. I wanted to try to make this part of the browser logic to make life easier for add-ons, but I also don't want to limit their power. I can imagine add-ons doing different things to handle this on their own (canceling an existing request vs. avoiding sending a new request), so perhaps this bug should just be a WONTFIX.

Comment 4

[:Margaret Leibovic]

Let's just make add-ons deal with this :)