IRC channels prefixed with "##" are difficult to filter in the awesometab.

RESOLVED FIXED

Status

defect
--
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: nhnt11, Assigned: nhnt11)

Tracking

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
We ignore single character channel prefixes already, we should ignore the double hash prefix too (it's used quite a bit on freenode for example).
(Assignee)

Comment 1

5 years ago
Posted patch 1007422.patch (obsolete) — Splinter Review
(Assignee)

Updated

5 years ago
Attachment #8424486 - Flags: review?(aleth)

Comment 2

5 years ago
Comment on attachment 8424486 [details] [diff] [review]
1007422.patch

Review of attachment 8424486 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8424486 - Flags: review?(aleth) → review+
Can we add some comments in there before committing? That code is already pretty confusing and now it looks like we're adding a special case to it? Thanks.
(Assignee)

Comment 4

5 years ago
Florian approved the comment on IRC (http://log.bezut.info/instantbird/today/#m286), so carrying forward the r+.
Assignee: nobody → nhnt11
Attachment #8424486 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8424841 - Flags: review+
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/comm-central/rev/8297e3902054
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.