Closed
Bug 1007422
Opened 10 years ago
Closed 10 years ago
IRC channels prefixed with "##" are difficult to filter in the awesometab.
Categories
(Instantbird Graveyard :: Conversation, defect)
Instantbird Graveyard
Conversation
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: nhnt11, Assigned: nhnt11)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.40 KB,
patch
|
nhnt11
:
review+
|
Details | Diff | Splinter Review |
We ignore single character channel prefixes already, we should ignore the double hash prefix too (it's used quite a bit on freenode for example).
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8424486 -
Flags: review?(aleth)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8424486 [details] [diff] [review] 1007422.patch Review of attachment 8424486 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8424486 -
Flags: review?(aleth) → review+
|
||
Comment 3•10 years ago
|
||
Can we add some comments in there before committing? That code is already pretty confusing and now it looks like we're adding a special case to it? Thanks.
|
|
Assignee | |
Comment 4•10 years ago
|
||
Florian approved the comment on IRC (http://log.bezut.info/instantbird/today/#m286), so carrying forward the r+.
Assignee: nobody → nhnt11
Attachment #8424486 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8424841 -
Flags: review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
https://hg.mozilla.org/comm-central/rev/8297e3902054
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•