1007451 - Get some nasty errors and a fatal exception running 'make test' on Mac

Status: VERIFIED FIXED

(Hello (Loop) :: Server, defect)

Description

[James Bonacci [:jbonacci]]

I use brew to install Redis
I get Redis running
I install loop-server and run 'make test'
This is what I see:
https://jbonacci.pastebin.mozilla.org/5096052

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

OS X specific bug, doing "uname -n 8191" before running should make the files thing go away.  We need to do that automatically somewhere...

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

By which I _actually_ meant to type "ulimit -n 8191".

Comment 3

[James Bonacci [:jbonacci]]

:dmose yea, I figured "ulimit" over "uname" :-)

Yep, running ulimit helps a lot.
1. Get Redis running
2. ulimit -n 8191
3. make test

We probably should set this up automatically for Mac, anyway.
Not sure Linux or Windows needs it so maybe make it optional.

Comment 4

[Rémy Hubscher (:natim)]

We probably don't want to setup it automatically since it is a system configuration. http://stackoverflow.com/questions/19981065/nodejs-error-emfile-too-many-open-files-on-mac-os

Comment 5

[Rémy Hubscher (:natim)]

I have added a note about it in the README.

https://github.com/mozilla-services/loop-server/commit/188a224c81c37ab55a9b9b1f0a891586986fa6a6

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

Setting it with launchctl makes the change system wide, that's correct.  However, using ulimit from a shell or shell script that shell and its sub-processes.  In the interest of avoiding forced manual steps, I believe the originally proposed solutions serves us better.

Comment 7

[Dan Mosedale (:dmosedale, :dmose)]

s/script/script only effects/

Comment 8

[James Bonacci [:jbonacci]]

So, this is looking decent on the first half of the tests.
Only the MongoDB stuff fails:
https://jbonacci.pastebin.mozilla.org/5212131

But, on the remaining tests, I still see significant errors and an exception:
https://jbonacci.pastebin.mozilla.org/5212142


I will see how this looks on Linux AWS...

Comment 9

[James Bonacci [:jbonacci]]

Over on the ubuntu side I see this:
https://jbonacci.pastebin.mozilla.org/5212343

Comment 10

[Alexis Metaireau (:alexis)]

James, can you update to master and tell if that works better? Thanks.

Comment 11

[James Bonacci [:jbonacci]]

I think we are good here...