Closed
Bug 1007525
Opened 11 years ago
Closed 11 years ago
Mark xpcom/typelib/xpt/ as FAIL_ON_WARNINGS
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
Attachments
(1 file)
917 bytes,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
Now that bug 1006998 has been fixed, xpcom/typelib/xpt/src/ and xpcom/typelib/xpt/tests/ are warning-free and can be built with FAIL_ON_WARNINGS.
Here is a green Try build:
https://tbpl.mozilla.org/?tree=Try&rev=2e52cda302b2
Attachment #8419195 -
Flags: review?(bobbyholley)
Updated•11 years ago
|
Attachment #8419195 -
Flags: review?(bobbyholley) → review+
Comment 1•11 years ago
|
||
Is this before or after bug 1005321? I can swear that I added a bunch of warnings there (so sorry...)
Assignee | ||
Comment 2•11 years ago
|
||
status-firefox31:
--- → wontfix
status-firefox32:
--- → fixed
Comment 3•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Assignee | ||
Comment 4•11 years ago
|
||
(In reply to :Ehsan Akhgari (lagging on bugmail, needinfo? me!) from comment #1)
> Is this before or after bug 1005321? I can swear that I added a bunch of
> warnings there (so sorry...)
I filed this bug after you landed bug 1005321 and I fixed the resulting -Wdeprecated-write-strings warnings in bug 1006998.
You need to log in
before you can comment on or make changes to this bug.
Description
•