1007538 - [B2G][RIL] fix error handling of REQUEST_QUERY_FACILITY_LOCK

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

Seems we need to add |this.sendChromeMessage(options); return;| right after [1].

[1] http://hg.mozilla.org/mozilla-central/annotate/39578a226d51/dom/system/gonk/ril_worker.js#l5898

Comment 1

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

Attachment: 1007538.patch

Hi Edgar,

Could you help review this? Thank you~

Comment 2

[Edgar Chen [:edgar] (PTO untils 8/11, slow response)]

Comment on attachment 8419301 [details] [diff] [review]
1007538.patch

Nice catch!!
Shall we do the same thing for REQUEST_SET_FACILITY_LOCK?

Comment 3

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

(In reply to Edgar Chen [:edgar][:echen] from comment #2)
> Comment on attachment 8419301 [details] [diff] [review]
> 1007538.patch
> 
> Nice catch!!
> Shall we do the same thing for REQUEST_SET_FACILITY_LOCK?

Thanks for the review :)

For SET_FACILITY_LOCK, I think the current code looks fine. I mean, we need to query "retryCount" if SET_FACILITY_LOCK fails. We don't really need "retryCount" if the operation succeeds. However, as ril.h defines  |response" is int *
          * ((int *)response)[0] is the number of retries remaining, or -1 if unknown|,
it's also fine to keep that. How do you think?

Comment 4

[Edgar Chen [:edgar] (PTO untils 8/11, slow response)]

(In reply to Hsin-Yi Tsai  [:hsinyi] from comment #3)
> (In reply to Edgar Chen [:edgar][:echen] from comment #2)
> > Comment on attachment 8419301 [details] [diff] [review]
> > 1007538.patch
> > 
> > Nice catch!!
> > Shall we do the same thing for REQUEST_SET_FACILITY_LOCK?
> 
> Thanks for the review :)
> 
> For SET_FACILITY_LOCK, I think the current code looks fine. I mean, we need
> to query "retryCount" if SET_FACILITY_LOCK fails. We don't really need
> "retryCount" if the operation succeeds. However, as ril.h defines 
> |response" is int *
>           * ((int *)response)[0] is the number of retries remaining, or -1
> if unknown|,
> it's also fine to keep that. How do you think?

Yes, agree with you. Thank you :)

Comment 5

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

Thanks, Edgar!

https://hg.mozilla.org/integration/b2g-inbound/rev/97cfbfb61ebd

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/97cfbfb61ebd