Closed Bug 1007566 Opened 8 years ago Closed 8 years ago
Gecko FOTA packages should make sure /system is rw mounted
43 bytes, text/x-github-pull-request
|Details | Review|
While hacking on Flame, I noticed the bootable/recovery provided by T2Mobile mounts /system as ro (in bootable/recovery/etc/init.rc). Currently, our FOTA package checks that the /system partition is mounted, but not that it's rw mounted. This makes the FOTA to fail more or less silently.
Please find attached a pull request that adds an assert() call on doing a touch /system/bin/ I checked on Flame that it was doing the job: if I force mount /system as ro in recovery's init.rc, then the assert is hit and it stops the update process.
Attachment #8419991 - Flags: review?(gsvelto)
Comment on attachment 8419991 [details] [review] Link to Github https://github.com/mozilla-b2g/B2G/pull/345 LGTM with only one minor nit I've left on GitHub.
Attachment #8419991 - Flags: review?(gsvelto) → review+
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.