Closed
Bug 1007566
Opened 11 years ago
Closed 11 years ago
Gecko FOTA packages should make sure /system is rw mounted
Categories
(Firefox OS Graveyard :: GonkIntegration, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.0 S2 (23may)
People
(Reporter: gerard-majax, Assigned: gerard-majax)
References
Details
(Whiteboard: [systemsfe])
Attachments
(1 file)
While hacking on Flame, I noticed the bootable/recovery provided by T2Mobile mounts /system as ro (in bootable/recovery/etc/init.rc).
Currently, our FOTA package checks that the /system partition is mounted, but not that it's rw mounted. This makes the FOTA to fail more or less silently.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → lissyx+mozillians
Assignee | ||
Comment 1•11 years ago
|
||
Please find attached a pull request that adds an assert() call on doing a touch /system/bin/
I checked on Flame that it was doing the job: if I force mount /system as ro in recovery's init.rc, then the assert is hit and it stops the update process.
Attachment #8419991 -
Flags: review?(gsvelto)
Updated•11 years ago
|
Whiteboard: [systemsfe]
Assignee | ||
Updated•11 years ago
|
Status: NEW → ASSIGNED
Comment 2•11 years ago
|
||
Comment on attachment 8419991 [details] [review]
Link to Github https://github.com/mozilla-b2g/B2G/pull/345
LGTM with only one minor nit I've left on GitHub.
Attachment #8419991 -
Flags: review?(gsvelto) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Target Milestone: --- → 2.0 S2 (23may)
You need to log in
before you can comment on or make changes to this bug.
Description
•