Closed Bug 1007566 Opened 8 years ago Closed 8 years ago

Gecko FOTA packages should make sure /system is rw mounted

Categories

(Firefox OS Graveyard :: GonkIntegration, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.0 S2 (23may)

People

(Reporter: gerard-majax, Assigned: gerard-majax)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

While hacking on Flame, I noticed the bootable/recovery provided by T2Mobile mounts /system as ro (in bootable/recovery/etc/init.rc).

Currently, our FOTA package checks that the /system partition is mounted, but not that it's rw mounted. This makes the FOTA to fail more or less silently.
Assignee: nobody → lissyx+mozillians
Please find attached a pull request that adds an assert() call on doing a touch /system/bin/

I checked on Flame that it was doing the job: if I force mount /system as ro in recovery's init.rc, then the assert is hit and it stops the update process.
Attachment #8419991 - Flags: review?(gsvelto)
Whiteboard: [systemsfe]
Blocks: 1008094
Status: NEW → ASSIGNED
Comment on attachment 8419991 [details] [review]
Link to Github https://github.com/mozilla-b2g/B2G/pull/345

LGTM with only one minor nit I've left on GitHub.
Attachment #8419991 - Flags: review?(gsvelto) → review+
https://github.com/mozilla-b2g/B2G/commit/fbb5c75825f6cd3b2ff5fd2b3952b6a7b5b32a72
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S2 (23may)
You need to log in before you can comment on or make changes to this bug.