1007581 - Rename FindEncodingForLabel* methods to have shorter names

Status: RESOLVED WONTFIX

(Core :: Internationalization, enhancement)

Description

[Henri Sivonen (:hsivonen)]

Follow-up from bug 943268.

Comment 1

[Henri Sivonen (:hsivonen)]

Attachment: Rename

Note that this naming is consistent with DecoderForEncoding(), etc., methods.

Comment 2

[Masatoshi Kimura [:emk]]

I have a bit concern about the consistency with the WebIDL codegen. The codegen uses GetXxx() for fallible methods and Xxx() for infallible methods.
Can we drop the "EncodingUtils::" part? All methods are static anyway. "mozilla::dom::encoding::EncodingUtils::Foo()" looks a bit redundant to me.

Comment 3

[Masatoshi Kimura [:emk]]

Comment on attachment 8419276 [details] [diff] [review]
Rename

See comment #2.

Comment 4

[Henri Sivonen (:hsivonen)]

(In reply to Masatoshi Kimura [:emk] from comment #2)
> I have a bit concern about the consistency with the WebIDL codegen. The
> codegen uses GetXxx() for fallible methods and Xxx() for infallible methods.

Do you mean these names should start with "Get" even though these aren't getters?

> Can we drop the "EncodingUtils::" part? All methods are static anyway.
> "mozilla::dom::encoding::EncodingUtils::Foo()" looks a bit redundant to me.

Do you mean getting rid of the class in EncodingUtils while keeping the files names EncodingUtils.h/cpp?