Closed
Bug 1007756
Opened 12 years ago
Closed 12 years ago
Strip out redundant and broken code landed in bug 990074
Categories
(DevTools :: Debugger, defect)
DevTools
Debugger
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 32
People
(Reporter: mossop, Assigned: mossop)
References
Details
Attachments
(1 file)
|
2.30 KB,
patch
|
fitzgen
:
review+
|
Details | Diff | Splinter Review |
I spotted some console errors while using the add-on debugger. Digging I found that some of the code I added in bug 990074 was broken, attempting to use a window.location as an nsIURI. But tests are still passing. I had added the code to listen for windows through the observer service because I was sure that I couldn't get the window URI when we got notified through onNewGlobal yet it turns out that we do so either the platform changed or I just made a mistake.
Either way the other code is redundant and broken so we should get rid of it.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #8419792 -
Flags: review?(nfitzgerald)
|
||
Updated•12 years ago
|
Attachment #8419792 -
Flags: review?(nfitzgerald) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
|
||
Comment 3•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
|
||
Updated•8 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•