1007804 - Improve in-content prefs help button styling (OS X)

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Sören Hentzschel]

Attachment: screenshot shows the issue

The new help button in the in-content preferences (bug 989890) needs a better styling on OS X. The spec shows a gradient, but there is a solid color, the hover style should be lighter than the default state, but it's darker, the border color is wrong, the button is wider than high and the question mark is not centered. Please see the attached screenshot.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: HelpAlign.patch

The colors are after the specs of bug 989890 comment 6 -> I leave this.

But the issue with the width and the centering is addressed in this bug.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8419579 [details] [diff] [review]
HelpAlign.patch

Review of attachment 8419579 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/osx/preferences/in-content/preferences.css
@@ +14,5 @@
> +  -moz-margin-start: 0;
> +}
> +
> +.help-button > .button-box > .button-text {
> +  display: none;

Should this be in the shared preferences.css?

Comment 3

[Richard Marti (:Paenglab)]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #2)
> Comment on attachment 8419579 [details] [diff] [review]
> > +.help-button > .button-box > .button-text {
> > +  display: none;
> 
> Should this be in the shared preferences.css?

Only OS X has margins on -button-text which are adding space also when no text is shown. But it wouldn't have a negative effect on the other themes when in shared.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Yeah, let's move it to shared anyways since we don't intend to show the label for this button on any of the platforms.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: HelpAlign.patch

Moved the .button-text rule to shared.

Comment 6

[Richard Marti (:Paenglab)]

Try: https://tbpl.mozilla.org/?tree=Try&rev=9eb33eacb51d

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/ca454d8df934

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ca454d8df934

Comment 9

[Camelia Badau [:cbadau], Desktop Test Engineering]

Verified fixed on Mac OSX 10.8.5 using Firefox 32 Beta 4 (buildID: 20140804164216) and latest Nightly 34.0a1 (buildID: 20140806030201).