1007816 - add ability to bookmark a link

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The Gaia browser doesn't currently have the ability to bookmark a link.  (Firefox for Android does.)

This is useful when one wants to bookmark a link rather than what the link redirects to.  (This is particularly useful for emails, which often have links to auto-log-in that log you in and redirect somewhere else, but such links sometimes show up in the browser as well.  Examples of this in emails include the registration for https://app.thanx.com/ and United's mobile boarding passes.)

Steps to reproduce:
 1. load a page with links the browser (most Web pages)
 2. long press on a link

Actual results:  only options are "Open link in new tab" and "Cancel"

Expected results:  there's also a way to bookmark the link.  (If it's already bookmarked, maybe that UI shouldn't be there, or maybe it should be UI to unbookmark.)

Comment 1

[Kevin Grandon :kgrandon]

I believe this is slated for 2.1. Page 33 of the rocketbar spec: https://mozilla.app.box.com/shared/2tix674298wtc4e4hewh/1/1399872384/16451967037/1

Comment 2

[yifan [:yifan][:yliao]]

Attachment: pull request

Add 'add link to homescreen' button in browsercontextmenu for node name 'A' in system browser.

Comment 3

[Ben Francis [:benfrancis]]

Comment on attachment 8480472 [details] [review]
pull request

r+ from me, thanks.

Comment 4

[yifan [:yifan][:yliao]]

Merged into master
https://github.com/mozilla-b2g/gaia/pull/23415

TBPL
https://tbpl.mozilla.org/?rev=244f43a6cbc9f158dab79535eb2a5a6ed447f585&tree=Gaia-Try