Closed
Bug 1007836
Opened 11 years ago
Closed 11 years ago
Send 'tablet' flag with TelemetryPing info
Categories
(Toolkit :: Telemetry, defect)
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: mfinkle, Assigned: mfinkle)
References
Details
Attachments
(1 file)
|
1.20 KB,
patch
|
rnewman
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
We track whether the device is considered a tablet or phone. The UI is different so the UI telemetry is affected.
We set the flag here:
http://mxr.mozilla.org/mozilla-central/source/xpcom/base/nsSystemInfo.cpp#281
Attachment #8419594 -
Flags: review?(rnewman)
|
||
Comment 1•11 years ago
|
||
Let's do it and uplift it.
Assignee: nobody → mark.finkle
Status: NEW → ASSIGNED
OS: Linux → Android
Hardware: x86_64 → All
|
|
||
Updated•11 years ago
|
Attachment #8419594 -
Flags: review?(rnewman) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
Blocks: 997487
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
|
|
Assignee | |
Comment 4•11 years ago
|
||
Comment on attachment 8419594 [details] [diff] [review]
telemetry-tablet v0.1
[Approval Request Comment]
Bug caused by (feature/regressing bug #):
User impact if declined: We want to do before and after testing with telemetry
Testing completed (on m-c, etc.): Works fine on m-c
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none
Attachment #8419594 -
Flags: approval-mozilla-aurora?
|
||
Updated•11 years ago
|
status-firefox31:
--- → affected
status-firefox32:
--- → fixed
|
|
||
Updated•11 years ago
|
Attachment #8419594 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
|
Assignee | |
Comment 5•11 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•