100788 - Bugzilla helper incorrectly prepends http:// to non-http: URLs

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect, P3)

Description

[Robin Green]

Enter a non-http URL like https://sourceforge.net or ftp://ftp.kde.org in
bugzilla helper, fill in reqd fields, then click "open bugzilla entry form".
http:// will be incorrectly added to the start of the URL.

Comment 1

[Dave Miller [:justdave]]

-> Bugzilla Helper

Comment 2

[Gervase Markham [:gerv]]

So it will.

Gerv

Comment 3

[Gervase Markham [:gerv]]

Sorry, Dave, this one's coming back to you. Bugzilla Helper sends http:// URLs
as www.foo.com and ftp:// URLs as ftp://ftp.foo.com; it does this because before
people were getting double http://, because Bugzilla automatically adds it in
enter_bug.cgi somewhere.

This is Not My Problem. ;-)

Gerv

Comment 4

[Gervase Markham [:gerv]]

Reassigning.

Gerv

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

*** Bug 105119 has been marked as a duplicate of this bug. ***

Comment 6

[timeless]

Attachment: we discussed lots of complicated things, but after 11 screens hixie asked why i didn't do the simple thing to which i responded that he had complained about dataloss. he noted he was mistaken, so here's the version I intend to use

Comment 7

[Dave Miller [:justdave]]

Comment on attachment 56093 [details] [diff] [review]
we discussed lots of complicated things, but after 11 screens hixie asked why i didn't do the simple thing to which i responded that he had complained about dataloss. he noted he was mistaken, so here's the version I intend to use

r= justdave

Comment 8

[Gervase Markham [:gerv]]

This is obsoleted by templatisation, which fixes this problem.

Gerv

Comment 9

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 56093 [details] [diff] [review]
we discussed lots of complicated things, but after 11 screens hixie asked why i didn't do the simple thing to which i responded that he had complained about dataloss. he noted he was mistaken, so here's the version I intend to use

Templatisation schmemplatisation.

r=me because I can.  Even though it doesn't matter.  :)

Comment 10

[Dave Miller [:justdave]]

checked in.

/cvsroot/mozilla/webtools/bugzilla/enter_bug.cgi,v  <--  enter_bug.cgi
new revision: 1.57; previous revision: 1.56

Comment 11

[Gervase Markham [:gerv]]

caillon, that was inappropriate. The only thing you've achieved is to cause me
merge conflicts. You know quite well I'm totally rewriting this CGI over in bug
103953, and encouraging checkins to it when I say that are a bad idea is both
rude and pointless.

Gerv