1007909 - [Home2] Disable pinch-to-zoom while user is dragging an icon

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Kevin Grandon :kgrandon]

From the etherpad:

    Pinch-to-zoom may confuse a user

    Pinch-to-zoom can be done while dragging an icon

    If a user has many icons and he pinch-to-zoom, he may see a totally different set of icons

    Pinch-to-zoom 

    Consequence: a user may be disturbed by a unexpected layout change while dragging an icon

    Example bugs

    Pinch to zoom can be done while dragging an icon, STR

    Enter Edit Mode

    Drag an icon with one finger

    Move a second finger diagonally (as to initiate a pinch to zoom action)

    If a user has many icons and he pinch-to-zoom, he may see a totally different set of icons, STR

    With more than 30 icons (eng build for instance) and 3 column layout, flick down to see the second group of 12 icons

    Pinch in

    You'll see none of the icons that were shown before

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Hey Cristian - could you give this a quick review? I really wish we could write some unit tests for this, but right now unit tests are not working in the dev_apps folder. I wonder if it might be worth it to stick them in another app for the time being.

Comment 2

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8419681 [details] [review]
Github pull request

LGTM. I realized of this behavior but I thought that it was expected :)

Comment 3

[Kevin Grandon :kgrandon]

Thanks! Landed: https://github.com/mozilla-b2g/gaia/commit/30db77397ab49c1ccfea6372e62c692b16655832

Comment 4

[Kevin Grandon :kgrandon]

Mass modify - set status-b2g-v2.0 fixed for fixed bugs under vertical homescreen dependency tree.