Closed Bug 1007943 Opened 11 years ago Closed 11 years ago

Tell the user they are offline immediately upon clicking a button

Categories

(Marketplace Graveyard :: General, defect)

Product:
Marketplace Graveyard
Component:
General
Platform:
Other
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: krupa.mozbugs, Assigned: kngo)

References

Details

steps to reproduce: 1. Launch marketplace app on your tarako device 2. Go offline 3. On the homepage, click on the Feedback button expected behavior: Upon clicking the Feedback button, there is a message informing the user that they need to be connected to the internet to submit Feedback. observed behavior: User can get to the feedback form and only after submitting feedback do we inform them that they are offline This is also true for Report abuse and other buttons which require the user to be online to complete that action. reproducible?: yes ashes: behavior seen on regular marketplace using inari/hamachi: no
Assignee: nobody → kngo
https://github.com/mozilla/yogafire/commit/c5f6c4c8e93b3a3b8e285877e334ae9e10e9ac55
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
User is not allowed to open feedback form while offline, but no error displayed when pressing the buttons.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Also , Report Abuse form can be opened even if phone is offline.
https://github.com/mozilla/yogafire/commit/8895b7ba9ea5084b71d27ce7092550cbb8bb6890
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
It may take upwards to ten seconds to detect that it is offline.
The issue is still reproducible for Report Abuse and for Privaci Policy, the "Oh no!" message is displayed in a new window instead of offline warning.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(In reply to Victor Carciu from comment #7) > The issue is still reproducible for Report Abuse and for Privacy Policy, the > "Oh no!" message is displayed in a new window instead of offline warning. I am talking about Privacy Policy opened from an app details page
This should be applied to Support Site and Homepage buttons too
(In reply to Victor Carciu from comment #9) > This should be applied to Support Site and Homepage buttons too As a comparison, all buttons should have the same behavior as the ones from homepage when offline(Get help, Feedback , Terms of use or Privacy Policy from "Home" tab are working as expected)
https://github.com/mozilla/yogafire/commit/6f14db6ceb39c20ae74eb9fca5ed69792130cbf4
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Verified as fixed
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.