1008081 - Remove "node" column from tokenserver "users" table

Status: RESOLVED FIXED

(Cloud Services Graveyard :: Server: Token, defect)

Description

[Ryan Kelly [:rfkelly]]

Once the fix from Bug 1002898 has been rolled out, we can do a second db migration to remove the no-longer-in-use "node" column from the "users" table.

Comment 1

[Ryan Kelly [:rfkelly]]

Attachment: ts-remove-node-column.diff

The previous migration is out in prod, we can now drop this column.

Comment 2

[Toby Elliott [:telliott]]

Comment on attachment 8444909 [details] [diff] [review]
ts-remove-node-column.diff

Review of attachment 8444909 [details] [diff] [review]:
-----------------------------------------------------------------

Sweet. Stylistically, I'm a little nervous about removing the explicit table references from the join; it'll work, but it's a potential source of mysterious errors in the future if someone were to put back a node column. That's probably being excessively paranoid, though.

Comment 3

[Ryan Kelly [:rfkelly]]

> I'm a little nervous about removing the explicit table references from the join

Fair.  I'll try putting them back in under an explicit alias and see how it affects overall readability.

Comment 4

[Ryan Kelly [:rfkelly]]

Committed with the explicit table reference restored:
https://github.com/mozilla-services/tokenserver/commit/3fe277d62a0d1ec58145dd7cba7a4ae903d82633

Comment 5

[Ryan Kelly [:rfkelly]]

jbonacci, let's not verify this until we actually get the column dropped as part of the next tokenserver deployment.