Closed Bug 1008146 Opened 10 years ago Closed 9 years ago

Break up dom/imptests/editing/conformancetest/test_runtest.html

Categories

(Core :: DOM: Editor, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1063632

People

(Reporter: ayg, Assigned: ayg)

References

Details

Attachments

(1 file)

This test file takes about six minutes to run on my machine.  This makes it a huge pain to bisect any regressions.  It would be nice to break it up.  This would have to happen upstream, naturally.  I'm not quite sure how best to do it, is the thing.  Artificially splitting the tests up into lots of different files seems awkward, but I don't see a better way.
This is fixed upstream, now syncing.  Note: some platforms had test_runtest.html disabled due to timeouts/OOM (see blocking bugs), and this will no longer be the case.  If any of the split-up tests are still too big, they'll have to be disabled separately.
Blocks: 1104433, 886301
Status: NEW → ASSIGNED
Attached patch PatchSplinter Review
Do you want to rubber-stamp this?  It should in theory just be a sync to upstream followed by regenerating the failures.  I looked over the local changes to the tests and synced them upstream as appropriate.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=20b59e2e3256
Attachment #8644348 - Flags: review?(Ms2ger)
Where's upstream nowadays?
https://dvcs.w3.org/hg/editing/ is the one I used.  I just deleted the GitHub one for now, because they had fallen out of sync and I didn't want to maintain both.  Anne is interested in moving it to the WHATWG's GitHub, which I'm in favor of if we can get redirects set up.  But until then, the W3C one is authoritative.
Comment on attachment 8644348 [details] [diff] [review]
Patch

Review of attachment 8644348 [details] [diff] [review]:
-----------------------------------------------------------------

It looks like I needed to update dom/imptests/moz.build too for failures/editing/conformancetest/run/ to get picked up.  New try push with that change: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4fd2c1c25eba
Comment on attachment 8644348 [details] [diff] [review]
Patch

rs=me
Attachment #8644348 - Flags: review?(Ms2ger) → review+
These tests are being deleted soon in favor of wpt anyway, so I'm not going to bother re-fixing this.  Some of them will need to be disabled on Android/B2G when they get imported into wpt.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: