1008248 - Split shared headers.css into building-block and web-component stylesheets

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Wilson Page [:wilsonpage]]

Currently `shared/style/headers.css` is supporting both old building blocks and new web-components header styling. We should create a dedicated gaia-header.css to style just the new <gaia-header> element.

Comment 1

[jachen]

Arnau- let me know if you have time to take a look at this.

Comment 2

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

(In reply to jachen from comment #1)
> Arnau- let me know if you have time to take a look at this.

Sure, no problem.

Comment 3

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: patch in github

Comment 4

[Wilson Page [:wilsonpage]]

Comment on attachment 8424890 [details] [review]
patch in github

Only time for a quick scan, but looks good at first glance. Couple of issues/queries:

- Why are there icon PNGs for actions that aren't configurable (eg. send.png, compose.png). I owuld have thought it was the component user's job to bring along these kind of assets.
- Not sure why we still need <header> in the template.

Comment 5

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

PNGs are there because some app owners decided to move those icons used in several apps, as a way to have them centralized and easier to update.
We will be able to remove them from the component when we support icon fonts :)

I'm using <header> in the template as a container to duplicate attributes like skin, so children get the right styles.

Comment 6

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Merged: e6548220ac8034c1952419aaab6db6c2de25c899