1008286 - clang warning (treated as error) in disable-unified build: nsProtocolProxyService.cpp:666:12: error: unused variable 'kProxyType_UNKNOWN' [-Werror,-Wunused-const-variable]

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
Build with this mozconfig, with clang (I'm using version 3.5):
 ac_add_options --enable-debug --disable-optimize
 ac_add_options --enable-warnings-as-errors
 ac_add_options --disable-unified-compilation

ACTUAL RESULTS:
Build error:
netwerk/base/src/nsProtocolProxyService.cpp:666:12: error: unused variable 'kProxyType_UNKNOWN' [-Werror,-Wunused-const-variable]

This variable is indeed unused and should be removed.

(I think clang doesn't warn about it in unified builds because there, we're #including the .cpp file, and clang assumes that there could be other #includers that have usages.)

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1

Comment 2

[Daniel Holbert [:dholbert]]

MXR search proving that this variable is indeed unused:
 http://mxr.mozilla.org/mozilla-central/search?string=kProxyType_UNKNOWN

Comment 3

[Daniel Holbert [:dholbert]]

Thanks for the review! I'll land this myself in a bit; no need for checkin-needed.

Comment 4

[Daniel Holbert [:dholbert]]

Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/2401ac3b2a9b

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2401ac3b2a9b