1008312 - clang warning in disable-unified builds: nsDOMClassInfo.cpp:574:1: warning: unused function 'WrapNative' [-Wunused-function]

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Daniel Holbert [:dholbert]]

STR: Build with clang (I'm using 3.5) and with this mozconfig option:
 ac_add_options --disable-unified-compilation

Actual results:
{
dom/base/nsDOMClassInfo.cpp:574:1: warning: unused function 'WrapNative' [-Wunused-function]
}

(I'm pretty sure this would be treated as an error if you also had the --enable-warnings-as-errors mozconfig option. I'm not building with that right now, because --disable-unified-compilation busts it too much due to issues like this one.)

Comment 1

[Daniel Holbert [:dholbert]]

Note that there are two different WrapNative functions. Looks like only one of them is unused, and the other is used.

Comment 2

[Daniel Holbert [:dholbert]]

er, four different WrapNative functions.

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: fix v1

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/62163878c694