Closed Bug 1008312 Opened 6 years ago Closed 6 years ago

clang warning in disable-unified builds: nsDOMClassInfo.cpp:574:1: warning: unused function 'WrapNative' [-Wunused-function]

Categories

(Core :: DOM: Core & HTML, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

STR: Build with clang (I'm using 3.5) and with this mozconfig option:
 ac_add_options --disable-unified-compilation

Actual results:
{
dom/base/nsDOMClassInfo.cpp:574:1: warning: unused function 'WrapNative' [-Wunused-function]
}

(I'm pretty sure this would be treated as an error if you also had the --enable-warnings-as-errors mozconfig option. I'm not building with that right now, because --disable-unified-compilation busts it too much due to issues like this one.)
Note that there are two different WrapNative functions. Looks like only one of them is unused, and the other is used.
Component: DMD → DOM
er, four different WrapNative functions.
Attached patch fix v1Splinter Review
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #8420256 - Flags: review?(peterv)
Attachment #8420256 - Flags: review?(peterv) → review+
https://hg.mozilla.org/mozilla-central/rev/62163878c694
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
See Also: → 1032644
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.