Closed
Bug 1008336
Opened 10 years ago
Closed 10 years ago
clang warning in disable-unified builds: js/src/gc/RootMarking.cpp:194:1: warning: unused function 'MarkIfGCThingWord' [-Wunused-function]
Categories
(Core :: JavaScript: GC, defect)
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
1.59 KB,
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
Disable-unified builds hit this build warning, in clang: { js/src/gc/RootMarking.cpp:194:1: warning: unused function 'MarkIfGCThingWord' [-Wunused-function] } (This warning is effectively disabled for unified builds.) The function is does actually have one usage, but it's inside an #ifdef. The function should be moved inside the same #ifdef.
Assignee | ||
Comment 1•10 years ago
|
||
Similarly, IsAddressableGCThing() is only used in MarkIfGCThingWord(), so it needs to be guarded as well or else we'll get warnings for it.
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8420268 -
Flags: review?(wmccloskey) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/91b7dcd04e65
Blocks: buildwarning
Flags: in-testsuite-
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/91b7dcd04e65
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•