Closed Bug 1008336 Opened 5 years ago Closed 5 years ago

clang warning in disable-unified builds: js/src/gc/RootMarking.cpp:194:1: warning: unused function 'MarkIfGCThingWord' [-Wunused-function]

Categories

(Core :: JavaScript: GC, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Disable-unified builds hit this build warning, in clang:
{
 js/src/gc/RootMarking.cpp:194:1: warning: unused function 'MarkIfGCThingWord' [-Wunused-function]
}
(This warning is effectively disabled for unified builds.)


The function is does actually have one usage, but it's inside an #ifdef. The function should be moved inside the same #ifdef.
Similarly, IsAddressableGCThing() is only used in MarkIfGCThingWord(), so it needs to be guarded as well or else we'll get warnings for it.
Attached patch fixSplinter Review
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #8420268 - Flags: review?(wmccloskey)
Attachment #8420268 - Flags: review?(wmccloskey) → review+
https://hg.mozilla.org/mozilla-central/rev/91b7dcd04e65
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
See Also: → 1032644
You need to log in before you can comment on or make changes to this bug.