1008420 - Split out a refcountless nsArray base class

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Andrew McCreight [:mccr8]]

I keep needing this, so I should just get it reviewed and landed.

Comment 1

[Andrew McCreight [:mccr8]]

Currently, nsArray uses threadsafe refcounting, while nsArrayCC uses non-threadsafe refcounting, but inherits from nsArray, thus shadowing the refcounting implementation of nsArray.  I am going to create a new nsArrayBase class that has no refcounting, and then make nsArray and nsArrayCC inherit from it.

Comment 2

[Benjamin Smedberg]

I don't understand. The only reason I can see somebody needing nsArray is because you need to pass it around to scriptable stuff. Otherwise why not just use nsTArray?

Arguably we should get rid of nsIArray/nsArray/nsArrayCC altogether.

Comment 3

[Andrew McCreight [:mccr8]]

I don't know why anybody uses it, I'm just trying to get rid of the shadowing of mRefCnt.

Comment 4

[Andrew McCreight [:mccr8]]

(Because if I can statically prevent the shadowing of mRefCnt I can prevent a certain class of cycle collector errors like bug 1004630.)

Comment 5

[Andrew McCreight [:mccr8]]

Attachment: part 1 - Delete trailing whitespace from nsArray.

I'll give bsmedberg the right of first refusal here, in case he has some objections.

try run: https://tbpl.mozilla.org/?tree=Try&rev=6cabd1d69357

Comment 6

[Andrew McCreight [:mccr8]]

Attachment: part 2 - Split out a refcountless nsArray base class.

Comment 7

[Andrew McCreight [:mccr8]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/cdd9cd53b362
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/a0d2fc4bb053

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cdd9cd53b362
https://hg.mozilla.org/mozilla-central/rev/a0d2fc4bb053