1008626 - Remove unneeded capabilities that are returned from the browser

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[David Burns :automatedtester]

We no longer need javaScriptEnabled and cssSelectors capabilities so these can be removed from what is returned.

The following lines will need to be deleted.

http://dxr.mozilla.org/mozilla-central/source/testing/marionette/marionette-server.js#562

http://dxr.mozilla.org/mozilla-central/source/testing/marionette/marionette-server.js#564

Comment 1

[Shashank VRSN Sabniveesu]

Attachment: BUG 1008626 - Remove no longer need javaScriptEnabled and cssSelectors capabili\ ties that are returned from the browser r=automatedtester

Removed no longer need javaScriptEnabled and cssSelectors capabili\
ties that are returned from the browser r=automatedtester

Comment 2

[David Burns :automatedtester]

Try 
https://tbpl.mozilla.org/?tree=Try&rev=34104f0215ab
https://tbpl.mozilla.org/?tree=Try&rev=9f8c715ac10d

Comment 3

[David Burns :automatedtester]

Thanks for the patch, I will be running it through try to make sure that it works without breaking one of the dependencies.

Once this looks good I will be pushing it into the tree

Thanks again!

Comment 4

[Shashank VRSN Sabniveesu]

Thanks for accepting.

* Is it necessary that I put a 'needinfo' in spite of a 'review?' ?
* Do reviewers give a 'review+' only after the tbpl tests complete but not any before?

Thanks,
Shashank

Comment 5

[David Burns :automatedtester]

I have a search for needinfo for me which I look at before my review queue :)

In this case it doesnt matter when I do r+ but would like to see if there are test suites that fail before I review it

Comment 6

[David Burns :automatedtester]

Helps if I push the patch to try...

https://tbpl.mozilla.org/?tree=Try&rev=684ec9e45609
https://tbpl.mozilla.org/?tree=Try&rev=82eee84f69d1

Comment 7

[David Burns :automatedtester]

Shashank, 

There are failures related to this change, if you click on the links in comment 6 it will take you to the test results. Could you update the tests accordingly

Comment 8

[Shashank VRSN Sabniveesu]

(In reply to David Burns :automatedtester from comment #7)
> Shashank, 
> 
> There are failures related to this change, if you click on the links in
> comment 6 it will take you to the test results. Could you update the tests
> accordingly
David Burns,

I don't understand what you mean by 'update tests accordingly'

Comment 9

[David Burns :automatedtester]

Could you update the tests to no longer have the items that you removed from your patch

Comment 10

[Shashank VRSN Sabniveesu]

Attachment: BUG 1008626 - Removed javaScriptEnabled and cssSelectors capabilities (no longer needed); updated tests accordingly r=automatedtester

Tests updated

Comment 11

[David Burns :automatedtester]

https://tbpl.mozilla.org/?tree=Try&rev=ac5a55d19ab5
https://tbpl.mozilla.org/?tree=Try&rev=2b9197044ad2

Comment 12

[David Burns :automatedtester]

Comment on attachment 8431267 [details] [diff] [review]
BUG 1008626 - Removed javaScriptEnabled and cssSelectors capabilities (no longer needed); updated tests accordingly r=automatedtester

Review of attachment 8431267 [details] [diff] [review]:
-----------------------------------------------------------------

This is brilliant! Thanks for doing this!.

Comment 13

[David Burns :automatedtester]

The next step is to have one of the sheriffs land this on inbound and if it sticks, which it should, then it will be merged into Mozilla-Central and be in the next nightly after that.

Please feel free to look for more bugs in this area! For marionette ones we have https://bugzilla.mozilla.org/buglist.cgi?cmdtype=runnamed&namedcmd=marionette-gfb&list_id=10375099 to help get you started

Comment 14

[Shashank VRSN Sabniveesu]

Dear MR David Burns,

I thank you for your encouragement and support through. Your suggestions led me to learn 'Marionette Testing'.

The above link is broken. Could you please resubmit?

Thanks,
Shashank

Comment 15

[David Lawrence [:dkl]]

(In reply to David Burns :automatedtester from comment #13)
> The next step is to have one of the sheriffs land this on inbound and if it
> sticks, which it should, then it will be merged into Mozilla-Central and be
> in the next nightly after that.
> 
> Please feel free to look for more bugs in this area! For marionette ones we
> have
> https://bugzilla.mozilla.org/buglist.
> cgi?cmdtype=runnamed&namedcmd=marionette-gfb&list_id=10375099 to help get
> you started

The shared query link is:

https://bugzilla.mozilla.org/buglist.cgi?cmdtype=dorem&remaction=run&namedcmd=marionette-gfb&sharer_id=397261

dkl

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e20435fd8c3e

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e20435fd8c3e