Closed Bug 1008626 Opened 6 years ago Closed 6 years ago

Remove unneeded capabilities that are returned from the browser

Categories

(Testing :: Marionette, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla32

People

(Reporter: automatedtester, Assigned: shashank)

Details

(Keywords: pi-marionette-server, pi-marionette-spec, Whiteboard: [good first bug][lang= js][mentor=automatedtester])

Attachments

(1 file, 1 obsolete file)

We no longer need javaScriptEnabled and cssSelectors capabilities so these can be removed from what is returned.

The following lines will need to be deleted.

http://dxr.mozilla.org/mozilla-central/source/testing/marionette/marionette-server.js#562

http://dxr.mozilla.org/mozilla-central/source/testing/marionette/marionette-server.js#564
Removed no longer need javaScriptEnabled and cssSelectors capabili\
ties that are returned from the browser r=automatedtester
Attachment #8427291 - Flags: review?(dburns)
Assignee: nobody → shashank16392
Thanks for the patch, I will be running it through try to make sure that it works without breaking one of the dependencies.

Once this looks good I will be pushing it into the tree

Thanks again!
Flags: needinfo?(dburns)
Flags: needinfo?(dburns)
Thanks for accepting.

* Is it necessary that I put a 'needinfo' in spite of a 'review?' ?
* Do reviewers give a 'review+' only after the tbpl tests complete but not any before?

Thanks,
Shashank
I have a search for needinfo for me which I look at before my review queue :)

In this case it doesnt matter when I do r+ but would like to see if there are test suites that fail before I review it
Shashank, 

There are failures related to this change, if you click on the links in comment 6 it will take you to the test results. Could you update the tests accordingly
Flags: needinfo?(dburns)
(In reply to David Burns :automatedtester from comment #7)
> Shashank, 
> 
> There are failures related to this change, if you click on the links in
> comment 6 it will take you to the test results. Could you update the tests
> accordingly
David Burns,

I don't understand what you mean by 'update tests accordingly'
Flags: needinfo?(dburns)
Could you update the tests to no longer have the items that you removed from your patch
Flags: needinfo?(dburns)
Tests updated
Attachment #8427291 - Attachment is obsolete: true
Attachment #8427291 - Flags: review?(dburns)
Attachment #8431267 - Flags: review?(dburns)
Flags: needinfo?(dburns)
Comment on attachment 8431267 [details] [diff] [review]
BUG 1008626 - Removed javaScriptEnabled and cssSelectors capabilities (no longer needed); updated tests accordingly r=automatedtester

Review of attachment 8431267 [details] [diff] [review]:
-----------------------------------------------------------------

This is brilliant! Thanks for doing this!.
Attachment #8431267 - Flags: review?(dburns) → review+
Keywords: checkin-needed
The next step is to have one of the sheriffs land this on inbound and if it sticks, which it should, then it will be merged into Mozilla-Central and be in the next nightly after that.

Please feel free to look for more bugs in this area! For marionette ones we have https://bugzilla.mozilla.org/buglist.cgi?cmdtype=runnamed&namedcmd=marionette-gfb&list_id=10375099 to help get you started
Dear MR David Burns,

I thank you for your encouragement and support through. Your suggestions led me to learn 'Marionette Testing'.

The above link is broken. Could you please resubmit?

Thanks,
Shashank
(In reply to David Burns :automatedtester from comment #13)
> The next step is to have one of the sheriffs land this on inbound and if it
> sticks, which it should, then it will be merged into Mozilla-Central and be
> in the next nightly after that.
> 
> Please feel free to look for more bugs in this area! For marionette ones we
> have
> https://bugzilla.mozilla.org/buglist.
> cgi?cmdtype=runnamed&namedcmd=marionette-gfb&list_id=10375099 to help get
> you started

The shared query link is:

https://bugzilla.mozilla.org/buglist.cgi?cmdtype=dorem&remaction=run&namedcmd=marionette-gfb&sharer_id=397261

dkl
https://hg.mozilla.org/mozilla-central/rev/e20435fd8c3e
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.