1008647 - Left padding of Label of BMB_bookmarksShowAllTop is wrong, separator isn't necessary

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Alice0775 White]

Attachment: screenshot

Comment 1

[:Gijs (he/him)]

Attachment: fix left padding and remove separator for top show all bookmarks item,

This is ugly, because I don't think this ever actually does have an icon, but it's the most contained and safely upliftable fix to this patch that I can see (as opposed to adding separate CSS rules on all the platforms) and brings the item in line with all the other non-checkbox items in that menu.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Gijs, please flag bugs that you start working on by needinfo'ing Marco or Jenn, and provide a point estimate (I've done that here)

Comment 3

[:Gijs (he/him)]

(In reply to :Gavin Sharp (email [e-mail]) from comment #2)
> Gijs, please flag bugs that you start working on by needinfo'ing Marco or
> Jenn, and provide a point estimate (I've done that here)

Thanks. To clarify, this is basically a followup from bug 986866 and we need to uplift that (it's tracking 30), hence taking care of it.

Comment 4

[Marco Mucci [:MarcoM]]

Added to Iteration.

Comment 5

[:Gijs (he/him)]

Comment on attachment 8422346 [details] [diff] [review]
fix left padding and remove separator for top show all bookmarks item,

https://hg.mozilla.org/integration/fx-team/rev/39e1fdf059c5

Comment 6

[:Gijs (he/him)]

Fixed on branches by the branch patch in bug 986866

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/39e1fdf059c5