Closed Bug 1008647 Opened 6 years ago Closed 6 years ago

Left padding of Label of BMB_bookmarksShowAllTop is wrong, separator isn't necessary

Categories

(Firefox :: Theme, defect)

32 Branch
x86_64
Windows 7
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 32
Tracking Status
firefox30 + fixed
firefox31 + fixed
firefox32 + fixed

People

(Reporter: alice0775, Assigned: Gijs)

References

Details

(Whiteboard: p=1 s=it-32c-31a-30b.2 [qa-])

Attachments

(2 files)

Attached image screenshot
No description provided.
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: firefox-backlog+
Summary: Left padding of Label of BMB_bookmarksShowAllTop is wrong on Windows7 Classic → Left padding of Label of BMB_bookmarksShowAllTop is wrong, separator isn't necessary
This is ugly, because I don't think this ever actually does have an icon, but it's the most contained and safely upliftable fix to this patch that I can see (as opposed to adding separate CSS rules on all the platforms) and brings the item in line with all the other non-checkbox items in that menu.
Attachment #8422346 - Flags: review?(mak77)
Gijs, please flag bugs that you start working on by needinfo'ing Marco or Jenn, and provide a point estimate (I've done that here)
Flags: needinfo?(mmucci)
Whiteboard: p=1 s=it-32c-31a-30b.2 [qa-]
(In reply to :Gavin Sharp (email gavin@gavinsharp.com) from comment #2)
> Gijs, please flag bugs that you start working on by needinfo'ing Marco or
> Jenn, and provide a point estimate (I've done that here)

Thanks. To clarify, this is basically a followup from bug 986866 and we need to uplift that (it's tracking 30), hence taking care of it.
Added to Iteration.
Flags: needinfo?(mmucci)
Attachment #8422346 - Flags: review?(mak77) → review+
Comment on attachment 8422346 [details] [diff] [review]
fix left padding and remove separator for top show all bookmarks item,

https://hg.mozilla.org/integration/fx-team/rev/39e1fdf059c5
Attachment #8422346 - Flags: checkin+
Fixed on branches by the branch patch in bug 986866
https://hg.mozilla.org/mozilla-central/rev/39e1fdf059c5
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.