1008785 - End frame of video has duration of entire video

Status: VERIFIED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

Spun off from bug 1005622, comment 32:

(In reply to Aaron Train [:aaronmt] from comment #32)
> Samsung Galaxy S5 (Android 4.4.2)
> Nightly  (05/08)
> 
> Video: https://www.youtube.com/watch?v=EKgIXFNSupA
> 
> Steps to Reproduce
> 
>   * Visit http://people.mozilla.org/~atrain/mobile/tests/big-buck-high.mp4
> and play the entirety of the clip
>   
>   * Tap the screen after the clip ends, see the video controls appear and
> the duration mention 0:34
>   
>   * Wait until the video controls re-appear on the screen (when what
> seemingly looks like a proper stop event) and see the duration doubled to
> 1:08
>   
>   * Tap the play button again, the clip will play and end at the original
> duration 0:34 despite having a timeline of 1:08. The last frame shown is
> white and the scrubber stops at 0:34. On tapping Pause, and Play again, the
> scrubber jumps to the 1:08 mark

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch

Don't mark the last video frame produced by MediaPluginReader has having duration of $mediaEndTime. It should be $mediaEndTime-$frameStartTime.

Regression from Bug 930829.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Since this was a regression from Bug 930829 which is in Firefox 27, this probably should be uplifted to Aurora and Beta.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Landed for 32.
https://hg.mozilla.org/integration/mozilla-inbound/rev/81f84748793b

We should uplift to Aurora 31 and Beta 30. This isn't worth a chemspil, so not noming for tracking 29.

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

ni? myself so I don't forget to request uplift...

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/81f84748793b

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8420730 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 930829
User impact if declined: MP4 videos on android won't end properly, once playback reaches the end they will continue to "play" blank data for the duration of the video again. This means the UI looks weird, and the media reports being twice it's actual duration.
Testing completed (on m-c, etc.): Been on m-c for a few days, verified fixed by QA.
Risk to taking this patch (and alternatives if risky): low.
String or IDL/UUID changes made by this patch: none.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a9e0fa9c20b5
https://hg.mozilla.org/releases/mozilla-beta/rev/e9cfd7705824

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/e9cfd7705824