1008835 - Unable to defer a new account to the Global Inbox

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[[e-mail]]

Creating a POP3 account deferred to the Global Inbox does not work. The error "Could not get IID for pop3: TypeError: srcServer.protocolInfo is undefined" on line 451 of AccountWizard.js was logged on the console during account creation.

Comment 1

[[e-mail]]

This is a regression from bug 861767. We try to get the protocol info for a server but the source server is only a JS object, not an actual server object. Getting the protocol info for the destination server should work though.

Comment 2

[:aceman]

I remember seeing this and fixing this somewhere...

Comment 3

[:aceman]

Yes, https://bug953339.bugzilla.mozilla.org/attachment.cgi?id=8379873 .

Should we use the same fix in the AccountWizard.js?

Comment 4

[[e-mail]]

The "Leave mail on server" checkbox is also affected.

Comment 5

[[e-mail]]

Attachment: Possible patch

This has some extra cleanup which may or may not make sense, since there is more code in the try block.

Comment 6

[[e-mail]]

Attachment: Proposed patch

Comment 7

[[e-mail]]

Sorry, I didn't see your email, I was busy testing my fix.

(In reply to aceman from comment #3)
> Yes, attachment 8379873 [details] [diff] [review].
> 
> Should we use the same fix in the AccountWizard.js?

Porting the aw-incoming.js part of that attachment would also work. It just so happens that we do have a real server available in this case.

Comment 8

[Philip Chee]

> -        IID = srcServer.protocolInfo.serverIID;
> +        IID = destServer.protocolInfo.serverIID;
>        } catch (ex) {
>          Components.utils.reportError("Could not get IID for " + srcServer.type + ": " + ex);

Shouldn't this be:
         Components.utils.reportError("Could not get IID for " + destServer.type + ": " + ex);

Comment 9

[[e-mail]]

(In reply to Philip Chee from comment #8)
> > -        IID = srcServer.protocolInfo.serverIID;
> > +        IID = destServer.protocolInfo.serverIID;
> >        } catch (ex) {
> >          Components.utils.reportError("Could not get IID for " + srcServer.type + ": " + ex);
> 
> Shouldn't this be:
>          Components.utils.reportError("Could not get IID for " +
> destServer.type + ": " + ex);

They have the same type (which is why they have the same protocol info).

Comment 10

[[e-mail]]

Pushed comm-central changeset 68dbbff90bd5.

Comment 11

[[e-mail]]

Comment on attachment 8420856 [details] [diff] [review]
Proposed patch

[Approval Request Comment]
Regression caused by (bug #): 861767
User impact if declined: Some SeaMonkey account wizard options are ignored
Testing completed (on m-c, etc.): Landed on c-c
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None

Comment 12

[Ian Neal]

Comment on attachment 8420856 [details] [diff] [review]
Proposed patch

a=me

Comment 13

[[e-mail]]

https://hg.mozilla.org/releases/comm-beta/rev/57703af67dd4

Comment 14

[[e-mail]]

https://hg.mozilla.org/releases/comm-aurora/rev/9539a7c8a0bf

Comment 15

[Justin Wood (:Callek)]

Landing to comm-release in prep of SeaMonkey 2.26.1

$ hg tip
changeset:   20189:2e990ad00dac
branch:      SEA_2_26_1_RELBRANCH
tag:         tip
user:        Neil Rashbrook <[e-mail]>
date:        Mon Jun 02 00:30:40 2014 +0100
summary:     Bug 1008835 Unable to defer a new account to the Global Inbox r=IanN a=IanN