Closed
Bug 1008835
Opened 11 years ago
Closed 11 years ago
Unable to defer a new account to the Global Inbox
Categories
(SeaMonkey :: MailNews: Account Configuration, defect)
SeaMonkey
MailNews: Account Configuration
Tracking
(seamonkey2.26 fixed, seamonkey2.27 fixed, seamonkey2.28 fixed, seamonkey2.29 fixed)
RESOLVED
FIXED
seamonkey2.29
People
(Reporter: neil, Assigned: neil)
References
Details
(Keywords: regression)
Attachments
(2 files)
1.50 KB,
patch
|
Details | Diff | Splinter Review | |
1004 bytes,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-aurora+
iannbugzilla
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
Creating a POP3 account deferred to the Global Inbox does not work. The error "Could not get IID for pop3: TypeError: srcServer.protocolInfo is undefined" on line 451 of AccountWizard.js was logged on the console during account creation.
Assignee | ||
Comment 1•11 years ago
|
||
This is a regression from bug 861767. We try to get the protocol info for a server but the source server is only a JS object, not an actual server object. Getting the protocol info for the destination server should work though.
Blocks: 861767
Yes, https://bug953339.bugzilla.mozilla.org/attachment.cgi?id=8379873 .
Should we use the same fix in the AccountWizard.js?
Assignee | ||
Comment 4•11 years ago
|
||
The "Leave mail on server" checkbox is also affected.
status-seamonkey2.26:
--- → affected
status-seamonkey2.27:
--- → affected
status-seamonkey2.28:
--- → affected
status-seamonkey2.29:
--- → affected
Assignee | ||
Comment 5•11 years ago
|
||
This has some extra cleanup which may or may not make sense, since there is more code in the try block.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Assignee | ||
Comment 6•11 years ago
|
||
Attachment #8420856 -
Flags: review?(iann_bugzilla)
Assignee | ||
Comment 7•11 years ago
|
||
Sorry, I didn't see your email, I was busy testing my fix.
(In reply to aceman from comment #3)
> Yes, attachment 8379873 [details] [diff] [review].
>
> Should we use the same fix in the AccountWizard.js?
Porting the aw-incoming.js part of that attachment would also work. It just so happens that we do have a real server available in this case.
Attachment #8420856 -
Flags: review?(iann_bugzilla) → review+
Comment 8•11 years ago
|
||
> - IID = srcServer.protocolInfo.serverIID;
> + IID = destServer.protocolInfo.serverIID;
> } catch (ex) {
> Components.utils.reportError("Could not get IID for " + srcServer.type + ": " + ex);
Shouldn't this be:
Components.utils.reportError("Could not get IID for " + destServer.type + ": " + ex);
Assignee | ||
Comment 9•11 years ago
|
||
(In reply to Philip Chee from comment #8)
> > - IID = srcServer.protocolInfo.serverIID;
> > + IID = destServer.protocolInfo.serverIID;
> > } catch (ex) {
> > Components.utils.reportError("Could not get IID for " + srcServer.type + ": " + ex);
>
> Shouldn't this be:
> Components.utils.reportError("Could not get IID for " +
> destServer.type + ": " + ex);
They have the same type (which is why they have the same protocol info).
Assignee | ||
Comment 10•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.29
Assignee | ||
Comment 11•11 years ago
|
||
Comment on attachment 8420856 [details] [diff] [review]
Proposed patch
[Approval Request Comment]
Regression caused by (bug #): 861767
User impact if declined: Some SeaMonkey account wizard options are ignored
Testing completed (on m-c, etc.): Landed on c-c
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None
Attachment #8420856 -
Flags: approval-comm-beta?
Attachment #8420856 -
Flags: approval-comm-aurora?
Comment 12•11 years ago
|
||
Comment on attachment 8420856 [details] [diff] [review]
Proposed patch
a=me
Attachment #8420856 -
Flags: approval-comm-beta?
Attachment #8420856 -
Flags: approval-comm-beta+
Attachment #8420856 -
Flags: approval-comm-aurora?
Attachment #8420856 -
Flags: approval-comm-aurora+
Assignee | ||
Comment 13•11 years ago
|
||
Assignee | ||
Comment 14•10 years ago
|
||
Comment 15•10 years ago
|
||
Landing to comm-release in prep of SeaMonkey 2.26.1
$ hg tip
changeset: 20189:2e990ad00dac
branch: SEA_2_26_1_RELBRANCH
tag: tip
user: Neil Rashbrook <neil@parkwaycc.co.uk>
date: Mon Jun 02 00:30:40 2014 +0100
summary: Bug 1008835 Unable to defer a new account to the Global Inbox r=IanN a=IanN
You need to log in
before you can comment on or make changes to this bug.
Description
•