1008852 - [Stingray] the unit tests for selectRect in selection_border_test.js is always failed

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[John Hu [:johnhu][:johu][:醬糊小弟]]

The tests of homescreen-stingray is not enabled by default. We need to enable it before reproducing this bug.

STR:
1. make clean
2. rename the _test_ folder to test in dev_apps/homescreen-stingray/
3. DEBUG=1 GAIA_DEVICE_TYPE=tv
4. open nightly to run unit tests
5. select selection_border_test.js
6. press "execute"

The followings are always failed:
  single selection
    a. selectRect
    b. selectRect rect1 and rect2
  multiple selection
    a. selectRect rect1 and rect2

Comment 1

[John Hu [:johnhu][:johu][:醬糊小弟]]

The followings are always failed:
  single selection
    a. selectRect
    b. deselectRect
    c. selectRect rect1 and rect2
  multiple selection
    a. selectRect rect1 and rect2
    b. deselectRect

Comment 2

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: patch for this bug

Please review this patch.

Comment 3

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8420868 [details] [review]
patch for this bug

r+ since it's simple and reasonable.

Comment 4

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Comment on attachment 8420868 [details] [review]
patch for this bug

r=me, thanks.

Comment 5

[John Hu [:johnhu][:johu][:醬糊小弟]]

merged to master:
https://github.com/mozilla-b2g/gaia/commit/e5e6b1900484a5cf39c8c0c54463cb03a1051aac