Closed Bug 1008890 Opened 8 years ago Closed 8 years ago
[Messages] Thread carrier header isn't localized correctly right after language switch
*** Follow-up from bug 1003384, comment 24 *** STR: 1. Open thread where career header is shown (eg. "phone_type | carrier_name"); 2. Press Home button; 3. Go to the language settings and change the language; 4. Switch back to the SMS app; Expected result: you should see "localized_phone_type | carrier_name" Actual result: "localized_label_for_carrier_unknown" is shown.
And I think carrier_name is not even localized, right?
(In reply to Julien Wajsberg [:julienw] from comment #1) > And I think carrier_name is not even localized, right? But carrier_name is custom string entered by user, how is it going to be localized?
Right, I was confused, I really thought about the phone_type, sorry.
The solution for this bug should help to resolve bug 963013 that requires separate styling for carrier name.
Assignee: nobody → azasypkin
Status: NEW → ASSIGNED
Hey Steve, could you please review this patch? It's prerequisite (well, partially) for new carrier header spec for bug 963013. Thanks!
Attachment #8430959 - Flags: review?(schung)
Whiteboard: [p=1] → [p=1][not-part-of-initial-sprint]
Target Milestone: --- → 2.0 S3 (6june)
Comment on attachment 8430959 [details] [review] GitHub pull request URL Thanks for the all the works! r=me and please squash it for merge
Attachment #8430959 - Flags: review?(schung) → review+
(In reply to Steve Chung [:steveck] from comment #6) > Comment on attachment 8430959 [details] [review] > GitHub pull request URL > > Thanks for the all the works! r=me and please squash it for merge Thanks for review! Travis is green, so check-in is needed :)
You need to log in before you can comment on or make changes to this bug.