1008890 - [Messages] Thread carrier header isn't localized correctly right after language switch

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Oleg Zasypkin [:azasypkin]]

*** Follow-up from bug 1003384, comment 24 ***

STR:
1. Open thread where career header is shown (eg. "phone_type | carrier_name");
2. Press Home button;
3. Go to the language settings and change the language;
4. Switch back to the SMS app;

Expected result: you should see "localized_phone_type | carrier_name"

Actual result: "localized_label_for_carrier_unknown" is shown.

Comment 1

[Julien Wajsberg [:julienw]]

And I think carrier_name is not even localized, right?

Comment 2

[Oleg Zasypkin [:azasypkin]]

(In reply to Julien Wajsberg [:julienw] from comment #1)
> And I think carrier_name is not even localized, right?

But carrier_name is custom string entered by user, how is it going to be localized?

Comment 3

[Julien Wajsberg [:julienw]]

Right, I was confused, I really thought about the phone_type, sorry.

Comment 4

[Oleg Zasypkin [:azasypkin]]

The solution for this bug should help to resolve bug 963013 that requires separate styling for carrier name.

Comment 5

[Oleg Zasypkin [:azasypkin]]

Attachment: GitHub pull request URL

Hey Steve, could you please review this patch? It's prerequisite (well, partially) for new carrier header spec for bug 963013.

Thanks!

Comment 6

[Steve Chung [:steveck]]

Comment on attachment 8430959 [details] [review]
GitHub pull request URL

Thanks for the all the works! r=me and please squash it for merge

Comment 7

[Oleg Zasypkin [:azasypkin]]

(In reply to Steve Chung [:steveck] from comment #6)
> Comment on attachment 8430959 [details] [review]
> GitHub pull request URL
> 
> Thanks for the all the works! r=me and please squash it for merge

Thanks for review! Travis is green, so check-in is needed :)

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/a3f9d7cac3c6c60ee29c060bef6f74e5a0e44fc2