Closed Bug 1008912 Opened 6 years ago Closed 6 years ago

'MMS' in sms app doesn't translate into other language

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(tracking-b2g:backlog)

RESOLVED FIXED
2.0 S5 (4july)
tracking-b2g backlog

People

(Reporter: yang.zhao, Assigned: azasypkin)

References

Details

(Whiteboard: [sprd309681][not-part-of-initial-sprint])

Attachments

(2 files)

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/535.19 (KHTML, like Gecko) Ubuntu/12.04 Chromium/18.0.1025.151 Chrome/18.0.1025.151 Safari/535.19

Steps to reproduce:

Step1:-Go to setting.
Step2:-Go to Language.
Step3:-Select other language except English,such as Hindi.
Step4:-Go to Message->compose message->attachment->select a picture.
Step5:-It shows 'MMS'  above the 'Send' button


Actual results:

It shows 'MMS' in English above the 'Send' button


Expected results:

'MMS' should display in Hindi.
Attached image 2012-01-01-11-02-51.png
see 'MMS' still in English.
The 'MMS' string is written in sms.css:
[data-message-type="mms"] #messages-send-button.has-counter:before {
  content: 'MMS';
  color: #FF4E00;
  font-size: 1.5rem;
  padding-left: -moz-calc(100% - 5rem);
  margin-top: -1.2rem;
}

Hi,Evelyn
    Do you have any good idea for this type of l10n issue?The string is written in css file.Looking forward to your reply and thank you very much!
Flags: needinfo?(ehung)
moving to the right component L10n -> SMS.
Component: Gaia::L10n → Gaia::SMS
yes, this is something I have in mind for a long time.

What's the expected target version to change this?
Flags: needinfo?(ehung) → needinfo?(yang.zhao)
(In reply to Julien Wajsberg [:julienw] from comment #4)
> yes, this is something I have in mind for a long time.
> 
> What's the expected target version to change this?
When the language change,the string "MMS" always displays in English.
Flags: needinfo?(yang.zhao)
I mean, which Firefox OS version do you need this change for?
Flags: needinfo?(yang.zhao)
(In reply to Julien Wajsberg [:julienw] from comment #6)
> I mean, which Firefox OS version do you need this change for?

v1.3t
Flags: needinfo?(yang.zhao)
not really fun.
blocking-b2g: --- → 1.3T?
ni? James, can your team take care of translations? 
is this a blocker for 1.3T?
Thanks
Flags: needinfo?(james.zhang)
Loop Arvin.
Assignee: nobody → arvin.zhang
Flags: needinfo?(james.zhang)
Whiteboard: [sprd309681]
triage: lets not block tarako with this. put this to backlog
blocking-b2g: 1.3T? → backlog
Status: UNCONFIRMED → NEW
Ever confirmed: true
Bug 1008127 changes the way the "MMS" text is displayed, so it should be easier to change this.
Depends on: 1008127
Hey Oleg, do you know if this bug is automatically fixed by bug 1008127?
Flags: needinfo?(azasypkin)
(In reply to Julien Wajsberg [:julienw] (away June 21 to 30) from comment #13)
> Hey Oleg, do you know if this bug is automatically fixed by bug 1008127?

Nope, it just prepared base for it by moving "MMS" text to a separate element. Patch for this bug just needs to add appropriate l10n Id.
Flags: needinfo?(azasypkin)
Assignee: arvin.zhang → azasypkin
Blocks: sms-sprint-4
Status: NEW → ASSIGNED
OS: All → Gonk (Firefox OS)
Hardware: All → ARM
Whiteboard: [sprd309681] → [sprd309681][not-part-of-initial-sprint]
Target Milestone: --- → 2.0 S5 (4july)
Hey Julien,

Here is the patch that uses localized "MMS" label for the following panels:

* message composer;
* thread list (to mark the thread with the last message being MMS).

Thanks!
Attachment #8448788 - Flags: review?(felash)
Comment on attachment 8448788 [details] [review]
GitHub pull request URL

r=me

works well, thanks !
Attachment #8448788 - Flags: review?(felash) → review+
(In reply to Julien Wajsberg [:julienw] from comment #16)
> Comment on attachment 8448788 [details] [review]
> GitHub pull request URL
> 
> r=me
> 
> works well, thanks !

Thanks for review!

Master: https://github.com/mozilla-b2g/gaia/commit/94daeb32785cdabc0db1504d38d545d5ac42aca5
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
blocking-b2g: backlog → ---
You need to log in before you can comment on or make changes to this bug.