Closed
Bug 1008941
Opened 10 years ago
Closed 10 years ago
Add test to verify dismissing the geolocation sharing hanger
Categories
(Core :: DOM: Geolocation, defect)
Core
DOM: Geolocation
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: mihaelav, Assigned: mihaelav, Mentored)
References
(Blocks 1 open bug)
Details
(Whiteboard: [lang=js])
Attachments
(1 file, 1 obsolete file)
4.14 KB,
patch
|
mihaelav
:
review+
|
Details | Diff | Splinter Review |
Steps: 1. Open a page which uses geolocation >> The location sharing hanger is displayed 2. Close the hanger without selecting any sharing option >> The location is not shared
Comment 1•10 years ago
|
||
Mihaela, this will become a browser chrome test, right? Andrei is not the appropriate mentor here. Please find the right one.
Whiteboard: [mentor=andrei.eftimie][lang=js]
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8446997 -
Flags: review?(gkeeley)
Assignee | ||
Updated•10 years ago
|
Whiteboard: [mentor=garvank][lang=js]
Updated•10 years ago
|
Mentor: gkeeley
Whiteboard: [mentor=garvank][lang=js] → [lang=js]
Comment on attachment 8446997 [details] [diff] [review] v1 Review of attachment 8446997 [details] [diff] [review]: ----------------------------------------------------------------- This 99% browser chrome testing and 1% geolocation, so I am going to defer to JDM for a review on this.
Attachment #8446997 -
Flags: review?(gkeeley) → review?(josh)
Comment 4•10 years ago
|
||
Comment on attachment 8446997 [details] [diff] [review] v1 Review of attachment 8446997 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/tests/browser/browser_bug1008941_dismissGeolocationHanger.js @@ +36,5 @@ > + > +function waitForPageLoad(aTab) { > + let deferred = Promise.defer(); > + > + let timeoutId = setTimeout(() => { I don't see the value of having a timeout here - the test will time out eventually anyways, and this gives us the possibility of intermittent oranges if the test machine stalls for some reason (such as a long GC). It's not that likely for the 20s timeout, but the 5s one below is definitely a possibility. ::: dom/tests/browser/position.html @@ +16,5 @@ > + result = document.getElementById("result"); > + > + if (navigator.geolocation) > + navigator.geolocation.getCurrentPosition(handlePosition, handleError, > + {enableHighAccuracy: false, timeout: 30000}); Why these options?
Attachment #8446997 -
Flags: review?(josh) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Updated based on review
Assignee: nobody → mihaela.velimiroviciu
Attachment #8446997 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Assignee | ||
Comment 6•10 years ago
|
||
remote: https://tbpl.mozilla.org/?tree=Try&rev=79a2324ddc3f
Assignee | ||
Comment 7•10 years ago
|
||
Comment on attachment 8455989 [details] [diff] [review] v1.1 Carrying over the r+, no failures in tbpl.
Attachment #8455989 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 8•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8cc209a3bd19
Keywords: checkin-needed
Comment 9•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8cc209a3bd19
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•