1008941 - Add test to verify dismissing the geolocation sharing hanger

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[Mihaela Velimiroviciu (:mihaelav)]

Steps:

1. Open a page which uses geolocation
>> The location sharing hanger is displayed

2. Close the hanger without selecting any sharing option
>> The location is not shared

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Mihaela, this will become a browser chrome test, right? Andrei is not the appropriate mentor here. Please find the right one.

Comment 2

[Mihaela Velimiroviciu (:mihaelav)]

Attachment: v1

Comment 3

[:garvan]

Comment on attachment 8446997 [details] [diff] [review]
v1

Review of attachment 8446997 [details] [diff] [review]:
-----------------------------------------------------------------

This 99% browser chrome testing and 1% geolocation, so I am going to defer to JDM for a review on this.

Comment 4

[Josh Matthews [:jdm]]

Comment on attachment 8446997 [details] [diff] [review]
v1

Review of attachment 8446997 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/tests/browser/browser_bug1008941_dismissGeolocationHanger.js
@@ +36,5 @@
> +
> +function waitForPageLoad(aTab) {
> +  let deferred = Promise.defer();
> +
> +  let timeoutId = setTimeout(() => {

I don't see the value of having a timeout here - the test will time out eventually anyways, and this gives us the possibility of intermittent oranges if the test machine stalls for some reason (such as a long GC). It's not that likely for the 20s timeout, but the 5s one below is definitely a possibility.

::: dom/tests/browser/position.html
@@ +16,5 @@
> +      result = document.getElementById("result");
> +
> +      if (navigator.geolocation)
> +        navigator.geolocation.getCurrentPosition(handlePosition, handleError,
> +                                                 {enableHighAccuracy: false, timeout: 30000});

Why these options?

Comment 5

[Mihaela Velimiroviciu (:mihaelav)]

Attachment: v1.1

Updated based on review

Comment 6

[Mihaela Velimiroviciu (:mihaelav)]

remote:   https://tbpl.mozilla.org/?tree=Try&rev=79a2324ddc3f

Comment 7

[Mihaela Velimiroviciu (:mihaelav)]

Comment on attachment 8455989 [details] [diff] [review]
v1.1

Carrying over the r+, no failures in tbpl.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8cc209a3bd19

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8cc209a3bd19