1009186 - Convert D3D9ThebesLayer to using Moz2D

Status: RESOLVED INVALID

(Core :: Graphics: Layers, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Attachment: Convert D3D9ThebesLayer to using Moz2D

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Convert D3D9ThebesLayer to using Moz2D

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Attachment: Convert D3D9ThebesLayer to using Moz2D

Comment 3

[Jeff Muizelaar [:jrmuizel]]

This basically just changes OpaqueRenderer and TransparentRenderer to return DrawTargets instead of gfxASurfaces.

Comment 4

[Bas Schouten (:bas.schouten)]

Do we still care now that OMTC is on? There's some chance we'll switch it off in Aurora? So maybe?

Comment 5

[Jeff Muizelaar [:jrmuizel]]

(In reply to Bas Schouten (:bas.schouten) from comment #4)
> Do we still care now that OMTC is on? There's some chance we'll switch it
> off in Aurora? So maybe?

Yeah maybe. It would be nice to still get the review. It should be pretty straight forward.

Comment 6

[Bas Schouten (:bas.schouten)]

Comment on attachment 8422431 [details] [diff] [review]
Convert D3D9ThebesLayer to using Moz2D

Review of attachment 8422431 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/d3d9/ThebesLayerD3D9.cpp
@@ +451,5 @@
>      return nullptr;
>    }
>    mD3D9ThebesSurface = result;
> +  // If the contents of this layer don't require component alpha in the
> +      // end of rendering, it's safe to enable Cleartype since all the Cleartype

nit: space

@@ +478,5 @@
>    if (mTmpTexture)
>  	  mTmpTexture->UnlockRect(0);
>  }
>  
> +

nit: whitespace

@@ +551,2 @@
>      if (ctx) {
> +	  ctx->GetDrawTarget()->DrawSurface(source,

nit: indentation

Comment 7

[Gregory Pappas [:gregp]]

D3D9 is gone