1009228 - Replace uses of RefPtr with nsRefPtr in gfx/layers/apz/

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Pretty trivial first bug. In gfx/layers/apz/src/AsyncPanZoomController.h defines the AsyncPanZoomController class, which contains a RefPtr<AsyncPanZoomAnimation> field. Convert this RefPtr to a nsRefPtr - there should be no changes needed other than changing the one declaration line, since the two are almost identical.

Comment 1

[Rafael Vieira]

Could I try?

Comment 2

[Georg Fritzsche [:gfritzsche]]

Sure, go ahead!

Comment 3

[Rafael Vieira]

Attachment: Bug 1009228: Converting RefPtr<AsyncPanZoomAnimation> field to nsRefPtr<AsyncPanZoomAnimation> at line 749

The patch!

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8422187 [details] [diff] [review]
Bug 1009228: Converting RefPtr<AsyncPanZoomAnimation> field to nsRefPtr<AsyncPanZoomAnimation> at line 749

Review of attachment 8422187 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good :)

Just one small thing: the commit messages we use generally don't refer to line numbers. For a patch this small it's best to just have a really simple commit message like "Bug 1009228 - Replace use of RefPtr with nsRefPtr". You can also append "r〓kats" since I have reviewed it. With those changes you'll have a patch ready for checkin. Thanks for the quick patch!

Comment 5

[Rafael Vieira]

Attachment: Bug 1009228 - Replace use of RefPtr with nsRefPtr

The new comment =)

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8422780 [details] [diff] [review]
Bug 1009228 - Replace use of RefPtr with nsRefPtr

Review of attachment 8422780 [details] [diff] [review]:
-----------------------------------------------------------------

Perfect, thanks! To have it checked in we generally set the checkin-needed keyword on the bug rather than use the checkin flags on the attachment. I can do that.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ec370de89abd

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ec370de89abd

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Nice work Rafael! I encourage you to find some more challenging bugs to work on, now that you have a few under your belt :)