Closed Bug 1009228 Opened 6 years ago Closed 6 years ago

Replace uses of RefPtr with nsRefPtr in gfx/layers/apz/

Categories

(Core :: Panning and Zooming, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: kats, Assigned: rafael1705r)

Details

(Whiteboard: [mentor=kats][lang=c++][good first bug])

Attachments

(1 file, 1 obsolete file)

Pretty trivial first bug. In gfx/layers/apz/src/AsyncPanZoomController.h defines the AsyncPanZoomController class, which contains a RefPtr<AsyncPanZoomAnimation> field. Convert this RefPtr to a nsRefPtr - there should be no changes needed other than changing the one declaration line, since the two are almost identical.
Could I try?
Sure, go ahead!
Assignee: nobody → rafael1705r
Comment on attachment 8422187 [details] [diff] [review]
Bug 1009228: Converting RefPtr<AsyncPanZoomAnimation> field to nsRefPtr<AsyncPanZoomAnimation> at line 749

Review of attachment 8422187 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good :)

Just one small thing: the commit messages we use generally don't refer to line numbers. For a patch this small it's best to just have a really simple commit message like "Bug 1009228 - Replace use of RefPtr with nsRefPtr". You can also append "r〓kats" since I have reviewed it. With those changes you'll have a patch ready for checkin. Thanks for the quick patch!
Attachment #8422187 - Flags: review?(bugmail.mozilla) → review+
The new comment =)
Attachment #8422187 - Attachment is obsolete: true
Attachment #8422780 - Flags: checkin?
Comment on attachment 8422780 [details] [diff] [review]
Bug 1009228 - Replace use of RefPtr with nsRefPtr

Review of attachment 8422780 [details] [diff] [review]:
-----------------------------------------------------------------

Perfect, thanks! To have it checked in we generally set the checkin-needed keyword on the bug rather than use the checkin flags on the attachment. I can do that.
Attachment #8422780 - Flags: checkin? → review+
https://hg.mozilla.org/mozilla-central/rev/ec370de89abd
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Nice work Rafael! I encourage you to find some more challenging bugs to work on, now that you have a few under your belt :)
You need to log in before you can comment on or make changes to this bug.