1009263 - nsCheapSet needs an efficient method for removing all entries

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Mats Palmgren (inactive)]

The only way to remove all entries today is to call EnumerateEntries and
return PL_DHASH_REMOVE, which isn't efficient, and it also wastes memory
by retaining the internal hashtable so it fails to deliver on its promise
in the documentation that claims:
 * A set that takes up minimal size when there are 0 or 1 entries in the set.

Comment 1

[Michael]

Think I might work on this, if you weren't planning to.

Comment 2

[Mats Palmgren (inactive)]

Attachment: fix

https://tbpl.mozilla.org/?tree=Try&rev=9ab404087e6e

Comment 3

[Mats Palmgren (inactive)]

Thanks, but I think the code that's already there in the destructor might work
as is, just needed to set mState = ZERO at the end.

Comment 4

[Mats Palmgren (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/833768f88824

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/833768f88824