1009328 - Change the signature of callBootstrapMethod to be more flexible for changes

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

At the moment the signature is 

function XPI_callBootstrapMethod(aId, aVersion, aType, aFile, aMethod, aReason, aExtraParams)

I"d like to change it to be 

function XPI_callBootstrapMethod(aAddon, aFile, aMethod, aReason, aExtraParams)

This way add-on objects, or pseudo `{ id: '', version, '', type: '' }` add-on like objects can be used easily, and one doesn't have to explicitly change every usage of callBootstrapMethod when adding more inputs.

So far this is part of my patch in bug 915376, but I would like to land this change separately.

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

Are you guys ok with this change?

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to Erik Vold [:erikvold] [:ztatic] from comment #0)
> function XPI_callBootstrapMethod(aAddon, aFile, aMethod, aReason,
> aExtraParams)

Yesplz.

Comment 3

[Dave Townsend [:mossop]]

Pseudo objects make me a little wary but maybe put some tests at the top of callBootstrapMethod to make sure it's been called with something that has all the properties it expects and throws a sane error if not.

Comment 4

[Erik Vold [:erikvold] (please needinfo? me)]

Due to the discussion in bug 1009332 I don't think bug 915376 is a dependency here any longer.

Comment 5

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Link to Github pull-request: https://github.com/mozilla/gecko-dev/pull/28

Comment 6

[Erik Vold [:erikvold] (please needinfo? me)]

https://tbpl.mozilla.org/?tree=Try&rev=f54d17b8098c

Comment 7

[Erik Vold [:erikvold] (please needinfo? me)]

Comment on attachment 8422686 [details] [review]
Link to Github pull-request: https://github.com/mozilla/gecko-dev/pull/28

updates made, changed aAddonDetails to be aAddon and removed the usages of aId, aVersion, and aType in `callBootstrapMethod`

Comment 8

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 8422686 [details] [review]
Link to Github pull-request: https://github.com/mozilla/gecko-dev/pull/28

r+ with a fixup to the error handling.

Comment 9

[Erik Vold [:erikvold] (please needinfo? me)]

fix was made, https://hg.mozilla.org/integration/fx-team/rev/b567c3e6934a

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back this out in http://hg.mozilla.org/integration/fx-team/rev/2518abfa2b68 for mochitest-browser-chrome-3 and mochitest-other test failures:
https://tbpl.mozilla.org/php/getParsedLog.php?id=39978301&tree=Fx-Team
https://tbpl.mozilla.org/php/getParsedLog.php?id=39978910&tree=Fx-Team

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

And mochitest-devtools just failed with https://tbpl.mozilla.org/php/getParsedLog.php?id=39979922&tree=Fx-Team

Comment 12

[Erik Vold [:erikvold] (please needinfo? me)]

https://tbpl.mozilla.org/?tree=Try&rev=2d86dd10fc8a

Comment 13

[Erik Vold [:erikvold] (please needinfo? me)]

I see the issue now.. update made, new try:

https://tbpl.mozilla.org/?tree=Try&rev=d8198d52cbb6

Comment 14

[Erik Vold [:erikvold] (please needinfo? me)]

saw another issue, trying again:

https://tbpl.mozilla.org/?tree=Try&rev=0d3d4dad85fa

Comment 15

[Erik Vold [:erikvold] (please needinfo? me)]

trying again:  https://tbpl.mozilla.org/?tree=Try&rev=0af7f1fe2b50

Comment 16

[Erik Vold [:erikvold] (please needinfo? me)]

trying again https://tbpl.mozilla.org/?tree=Try&rev=5e30a28ffc72

Comment 17

[Erik Vold [:erikvold] (please needinfo? me)]

https://tbpl.mozilla.org/?tree=Try&rev=e050ea16e86c

Comment 18

[Erik Vold [:erikvold] (please needinfo? me)]

https://hg.mozilla.org/integration/fx-team/rev/7c84d3461aa1

Comment 19

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/7c84d3461aa1