Closed
Bug 1009451
Opened 11 years ago
Closed 10 years ago
TypeError: tabs[i]._preview is undefined
Categories
(SeaMonkey :: OS Integration, defect)
Tracking
(seamonkey2.26 wontfix, seamonkey2.27 wontfix, seamonkey2.28 fixed, seamonkey2.29 fixed)
RESOLVED
FIXED
seamonkey2.30
People
(Reporter: neil, Assigned: neil)
Details
Attachments
(2 files)
|
877 bytes,
patch
|
mcsmurf
:
review+
iannbugzilla
:
approval-comm-aurora+
iannbugzilla
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
|
1.58 KB,
patch
|
Details | Diff | Splinter Review |
When you have exactly 21 tabs and you close a tab, the AeroPeek object turns itself on. However it tries to turn itself on for the tab you've just closed, which doesn't work, because we've already deleted the preview. This leaves AeroPeek in an inconsistent state.
|
Assignee | |
Comment 1•11 years ago
|
||
After removing the controller we check the preview count, and if the count drops to exactly 20 we enable AeroPeek, which tries to enable for the tab we're just deleting. The problem arises because we remove the controller after deleting the preview. If we remove the controller first, we will temporarily enable the preview, then re-disable it, and then the tab ordering gets updated.
|
|
Assignee | |
Comment 2•11 years ago
|
||
This version simply skips tabs that have no preview, presuming that they're being deleted.
|
|
Assignee | |
Updated•11 years ago
|
status-seamonkey2.26:
--- → affected
status-seamonkey2.27:
--- → affected
status-seamonkey2.28:
--- → affected
status-seamonkey2.29:
--- → affected
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8421589 [details] [diff] [review]
Possible patch
I like this one better, both work fine though :)
Attachment #8421589 -
Flags: review?(bugzilla) → review+
|
|
||
Updated•10 years ago
|
|
|
||
Updated•10 years ago
|
|
|
Assignee | |
Comment 4•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.30
|
|
Assignee | |
Comment 5•10 years ago
|
||
Comment on attachment 8421589 [details] [diff] [review]
Possible patch
[Approval Request Comment]
Regression caused by (bug #): 839891
User impact if declined: Aero Peek errors if you close the 21st tab
Testing completed (on m-c, etc.): Landed on c-c
Risk to taking this patch (and alternatives if risky): Low
String changes made by this patch: None
Attachment #8421589 -
Flags: approval-comm-beta?
Attachment #8421589 -
Flags: approval-comm-aurora?
Comment on attachment 8421589 [details] [diff] [review]
Possible patch
a=me
Attachment #8421589 -
Flags: approval-comm-beta?
Attachment #8421589 -
Flags: approval-comm-beta+
Attachment #8421589 -
Flags: approval-comm-aurora?
Attachment #8421589 -
Flags: approval-comm-aurora+
|
|
Assignee | |
Comment 7•10 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•