Closed Bug 1009517 Opened 9 years ago Closed 7 years ago

Enable web-platform-tests on Windows on Cedar

Categories

(Release Engineering :: General, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jgraham, Unassigned)

Details

Attachments

(2 files, 1 obsolete file)

Once the patches to make web-platform-tests work on Windows land it should be enabled on Cedar.
Attached patch bug1009517-mozharness (obsolete) — Splinter Review
Mozharness changes. The test_ file worked on my machine, but I'm not really sure how to pick paths that will work for anyone else. The prod_ file is untested; I was just guessing based on the other test configs.
Attachment #8421705 - Flags: review?(aki)
Updated buildbot config. Untested (is there a way to do that locally?)
Attachment #8421706 - Flags: review?(aki)
Comment on attachment 8421706 [details] [diff] [review]
bug1009517-buildbot

(In reply to James Graham [:jgraham] from comment #2)
> Created attachment 8421706 [details] [diff] [review]
> bug1009517-buildbot
> 
> Updated buildbot config. Untested (is there a way to do that locally?)

a) ./test-masters.sh will make sure a |buildbot checkconfig| won't have any problems.  It's best practice to run this before a review.

b) braindump/buildbot_related/builder_list.py will dump a list of builders for a master.
https://wiki.mozilla.org/ReleaseEngineering:TestingTechniques#builder_list.py_.2F_dump_master.py

So:

# list masters, to be able to choose
./setup-master.py -l
# choose a windows master, set it up
./setup-master.py bm109-tests1-windows bm109-tests1-windows
cd bm109-tests1-windows
# get a list of builders before the patch is applied
/src/clean/braindump/buildbot-related/builder_list.py master.cfg > ../../clean
# apply your patch to buildbot-configs (hg qpush?)
# get a list of builders after the patch is applied
/src/clean/braindump/buildbot-related/builder_list.py master.cfg > ../../dirty
# get the diff
diff ../../{clean,dirty} | tee > ../../builderdiff

In this case, you would get web-platform-tests for all windows Cedar slave platforms.
Attachment #8421706 - Flags: review?(aki) → review+
Comment on attachment 8421705 [details] [diff] [review]
bug1009517-mozharness

># HG changeset patch
># User James Graham <james@hoppipolla.co.uk>
># Date 1399990443 25200
>#      Tue May 13 07:14:03 2014 -0700
># Node ID 8f8df3dd167cdb69063c5986ca63a962b8b833c9
># Parent  99c4d4c961bd62aa83d33d733c31ae0aa1fc0a44
>Bug 1009517 - Add windows config for web-platform-tests.
>
>diff --git a/configs/web_platform_tests/prod_config_windows.py b/configs/web_platform_tests/prod_config_windows.py
>new file mode 100644
>--- /dev/null
>+++ b/configs/web_platform_tests/prod_config_windows.py
>@@ -0,0 +1,40 @@
>+# ***** BEGIN LICENSE BLOCK *****
>+# This Source Code Form is subject to the terms of the Mozilla Public
>+# License, v. 2.0. If a copy of the MPL was not distributed with this file,
>+# You can obtain one at http://mozilla.org/MPL/2.0/.
>+# ***** END LICENSE BLOCK *****
>+
>+# This is a template config file for web-platform-tests test.
>+
>+import os
>+import sys
>+
>+config = {
>+    # test harness options are located in the gecko tree
>+    "in_tree_config": "config/mozharness/web_platform_tests_config.py",
>+
>+    "exes": {
>+        'python': sys.executable,
>+        'virtualenv': [sys.executable, 'c:/mozilla-build/buildbotve/virtualenv.py'],
>+        'hg': 'c:/mozilla-build/hg/hg',
>+        'mozinstall': ['%s/build/venv/scripts/python' % os.getcwd(),
>+                       '%s/build/venv/scripts/mozinstall-script.py' % os.getcwd()],
>+    },
>+
>+    "options": [],
>+
>+    "default_actions": [
>+        'clobber',
>+        'download-and-extract',
>+        'create-virtualenv',
>+        'pull',
>+        'install',
>+        'run-tests',
>+    ],

In the prod config, I think you need read-buildbot-config.
That would result in removing default_actions from the config.

>+
>+    "find_links": [
>+        "http://pypi.pub.build.mozilla.org/pub",
>+    ],

I think we want "http://pypi.pvt.build.mozilla.org/pub" first.

I think we also need

    "buildbot_json_path": "buildprops.json",

    "default_blob_upload_servers": [
         "https://blobupload.elasticbeanstalk.com",
    ],

    "blob_uploader_auth_file" : os.path.join(os.getcwd(), "oauth.txt"),

If you're comfortable landing with the above fixes, that's fine.
If you want to send it back to me for a re-review, that's fine too.
Attachment #8421705 - Flags: review?(aki) → review+
Attachment #8421705 - Attachment is obsolete: true
Attachment #8421868 - Flags: review?(aki)
Attachment #8421868 - Flags: review?(aki) → review+
in production
mozharness patch in production
looks like it's done
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.