1009599 - Restoring from about:sessionrestore fails when there is more than one tab in the window

Status: VERIFIED FIXED

(Firefox :: Session Restore, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

When there is more than one tab in the current window, clicking the "Restore" button on about:sessionrestore opens a new window and restores the session into that. This broke with bug 1002843, we should fix that asap.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-1009599-Restoring-from-about-sessionrestore-fail.patch

Comment 2

[Steven MacLeod [:smacleod]]

Comment on attachment 8421804 [details] [diff] [review]
0001-Bug-1009599-Restoring-from-about-sessionrestore-fail.patch

Review of attachment 8421804 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/sessionstore/test/browser_aboutSessionRestore.js
@@ +2,5 @@
> +   http://creativecommons.org/publicdomain/zero/1.0/ */
> +
> +"use strict";
> +
> +const CRASH_STATE = {windows: [{tabs: [{entries: [{url: "about:mozilla" }]}]}]};

I don't really like these one line states, they put me in bracket hell. I'd
much prefer we just use multiple lines and indentation to call out the
structure more clearly.

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

(In reply to Steven MacLeod [:smacleod] from comment #2)
> > +const CRASH_STATE = {windows: [{tabs: [{entries: [{url: "about:mozilla" }]}]}]};
> 
> I don't really like these one line states, they put me in bracket hell. I'd
> much prefer we just use multiple lines and indentation to call out the
> structure more clearly.

Can do!

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/0b9a2f9abfff

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0b9a2f9abfff

Comment 6

[Cornel Ionce [:noni] [Hubs QA]]

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0
Mozilla/5.0 (Windows NT 6.2; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:30.0) Gecko/20100101 Firefox/32.0
Mozilla/5.0 (X11; Linux i686; rv:32.0) Gecko/20100101 Firefox/32.0

The session is restored into the same window, without generating a new one using latest Nightly, build ID: 20140515030202 if more than one tab in the current window.