Closed
Bug 1009617
Opened 11 years ago
Closed 11 years ago
Move screen properties from GaiaTestCase into GaiaDevice
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect, P4)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: zcampbell, Assigned: viorela)
References
Details
Attachments
(1 file)
These 3 methods/properties are more applicable to GaiaDevice as they represent device hardware.
change_orientation
screen_width
screen_orientation
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → viorela.ioia
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8453645 -
Flags: review?(zcampbell)
Attachment #8453645 -
Flags: review?(florin.strugariu)
|
||
Updated•11 years ago
|
Attachment #8453645 -
Flags: review?(florin.strugariu) → review+
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8453645 -
Flags: review?(dave.hunt)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8453645 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/21576
Looks good. I also checked and none of the gaiatest consumers that I know about use these methods, so it should be safe to land this.
Attachment #8453645 -
Flags: review?(dave.hunt) → review+
|
Reporter | |
Updated•11 years ago
|
Attachment #8453645 -
Flags: review?(zcampbell)
|
|
Reporter | |
Comment 3•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•