1009688 - Geolocation fails because the @mozilla.org/wifi/monitor;1 is undefined

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[Marco Castelluccio [:marco]]

This is the error I see in the error console:
Cc['@mozilla.org/wifi/monitor;1'] is undefined

Comment 1

[Josh Matthews [:jdm]]

Is this a mozilla.org build or a distro build?

Comment 2

[Marco Castelluccio [:marco]]

(In reply to Josh Matthews [:jdm] from comment #1)
> Is this a mozilla.org build or a distro build?

It is a distro build.

Comment 3

[Josh Matthews [:jdm]]

Which distro? I suspect this bug will be more usefully filed in another tracker.

Comment 4

[Marco Castelluccio [:marco]]

(In reply to Josh Matthews [:jdm] from comment #3)
> Which distro? I suspect this bug will be more usefully filed in another
> tracker.

Fedora 20.

Comment 5

[zzt]

I'm facing the same problem with Firefox 29.0.1 and Fedora 20 x86_64.

You can find the same bug at Redhat Bugzilla (responsible for Fedora Distribution): https://bugzilla.redhat.com/show_bug.cgi?id=1063739

Maybe somebody from Mozilla could help us, to identify the problem?

Comment 6

[Jan Horak [:jhorak]]

This is due to missing API key for Google geolocation API:
https://www.googleapis.com/geolocation/v1/geolocate?key=no-google-api-key

Comment 7

[Jan Horak [:jhorak]]

We need to specify --with-google-api-keyfile=file build option but we don't have the secret file for obvious reason.

Comment 8

[ocho]

(In reply to Jan Horak from comment #7)
> We need to specify --with-google-api-keyfile=file build option but we don't
> have the secret file for obvious reason.

So it can't/won't be fixed?

Comment 9

[Josh Matthews [:jdm]]

The geolocation key is separate from the specific error that's being described here. Obviously geolocation won't work regardless, but conflating the two is unhelpful.

Comment 10

[Josh Matthews [:jdm]]

We just require a null check when accessing this.wifiService in http://mxr.mozilla.org/mozilla-central/source/dom/system/NetworkGeolocationProvider.js#127 . That will stop the error that's being logged in the console as described in this bug. The actual geolocation request will continue to fail silently because of the missing key, which can be obtained by applying to Google: https://developers.google.com/maps/documentation/geocoding/index#api_key

Comment 11

[Marcos Caceres [:marcosc]]

Attachment: Make sure Cc["@mozilla.org/wifi/monitor;1"] returns something

Comment 12

[Marco Castelluccio [:marco]]

(In reply to Marcos Caceres [:marcosc] from comment #11)
> Created attachment 8428911 [details] [diff] [review]
> Make sure Cc["@mozilla.org/wifi/monitor;1"] returns something

Do you want this patch to be reviewed?

Comment 13

[Marco Castelluccio [:marco]]

(In reply to Josh Matthews [:jdm] from comment #10)
> The actual geolocation request will continue to fail silently
> because of the missing key, which can be obtained by applying to Google:
> https://developers.google.com/maps/documentation/geocoding/index#api_key

Maybe they could use the Mozilla location services?

Comment 14

[Josh Matthews [:jdm]]

(In reply to Marco Castelluccio [:marco] from comment #12)
> (In reply to Marcos Caceres [:marcosc] from comment #11)
> > Created attachment 8428911 [details] [diff] [review]
> > Make sure Cc["@mozilla.org/wifi/monitor;1"] returns something
> 
> Do you want this patch to be reviewed?

Setting the review flag helps!

Comment 15

[Marcos Caceres [:marcosc]]

@jdm, ok, now what happens? ^_^

Comment 16

[Josh Matthews [:jdm]]

You upload a patch which has an author header and a commit message, then set the checkin-needed keyword (along with a recent successful try push link), or someone else with commit access pushes the patch.

Comment 17

[Josh Matthews [:jdm]]

Please read https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F for more specific instructions for that first step.

Comment 18

[Marcos Caceres [:marcosc]]

Attachment: geo.patch

Added the author and subject to the patch to conform with hg. Will figure out the try server stuff next week.

Comment 19

[Marcos Caceres [:marcosc]]

Attachment: geo.patch

Improved the commit message. I missed in the notes that there is a convention for commit messages used in this project.

Comment 20

[(no longer active)]

This is simple enough that it doesn't require a try push.

https://hg.mozilla.org/integration/mozilla-inbound/rev/52204412c79b

Comment 21

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/52204412c79b

Comment 22

[Doug Turner (:dougt)]

https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/c59dde4e7998