1009734 - Firefox is issuing incorrect errors for WebGL

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Gregg Tavares]

Attachment: bogus-webgl-errors.html

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140506152807

Steps to reproduce:

1) Open the Web Console
2_ Run the attached file or go to

http://greggman.com/downloads/examples/bogus-webgl-errors.html




Actual results:

There are incorrect errors about WebGL in the console.




Expected results:

There should be no errors in the console


The specific issue is Firefox is checking if a texture is renderable at bindTexture time. This is incorrect behavior. A texture can not be checked for being valid until someone tries to render with it. It is perfectly legal WebGL to bind an invalid texture.

There are similar incorrect checks for binding framebuffers and renderbuffers (and buffers?)

Comment 1

[Gregg Tavares]

Any chance this bug can be fixed? It's really annoying to get BS warnings in the console. 

A typical use case is writing a function that auto sets filtering / mips for NPOT vs POT textures. To make it callable from anywhere it binds the texture because it can't assume it was already bound. So

    gl.bindTexture(..., tex);
    gl.texImage2D(..., img);
    setFilteringAndMipsForTexture(tex, img.width, img.height)

    function setFilteringAndMipsForTexture(tex, width, height) {
       gl.bindTexture(..., tex);  // generates incorrect warning in Firefox

Comment 2

[Kelsey Gilbert [:jgilbert]]

(In reply to Gregg Tavares from comment #1)
> Any chance this bug can be fixed? It's really annoying to get BS warnings in
> the console. 
> 
> A typical use case is writing a function that auto sets filtering / mips for
> NPOT vs POT textures. To make it callable from anywhere it binds the texture
> because it can't assume it was already bound. So
> 
>     gl.bindTexture(..., tex);
>     gl.texImage2D(..., img);
>     setFilteringAndMipsForTexture(tex, img.width, img.height)
> 
>     function setFilteringAndMipsForTexture(tex, width, height) {
>        gl.bindTexture(..., tex);  // generates incorrect warning in Firefox

Yeah, this should be fairly easy to fix.

Comment 3

[Kelsey Gilbert [:jgilbert]]

Attachment: 0001-Wait-until-draw-time-to-check-texture-completeness.patch

Neuter yet another myopic optimization.

Comment 4

[u480271]

Comment on attachment 8588855 [details] [diff] [review]
0001-Wait-until-draw-time-to-check-texture-completeness.patch

Review of attachment 8588855 [details] [diff] [review]:
-----------------------------------------------------------------

So we just need to take away code?

Comment 5

[Kelsey Gilbert [:jgilbert]]

  https://hg.mozilla.org/integration/mozilla-inbound/rev/a7dbe1bc7878

Comment 6

[Kelsey Gilbert [:jgilbert]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0088477e0349

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a7dbe1bc7878