100978 - Filters: new or edited AND resets to OR upon OK.

Status: VERIFIED FIXED

(MailNews Core :: Filters, defect)

Description

[laurel]

Using sep21 0.9.4 commercial branch

After OK to a new or edited filter setting for AND/"All of the following", the
AND resets to or and is written to rules.dat as OR.

1.  Launch message filters.
2.  Click New and set up a simple filter using AND/"All of the following".
3.  Confirm OK.  
4.  Look at the filter rules dialog again for that filter and see the AND has
reset to OR, likewise the rules.dat contains OR.

Comment 1

[laurel]

Same on trunk, too.
I messed up on the rules.dat issue in original description. The rules.dat writes
as AND if you don't edit, so existing AND filters intact.

Comment 2

[R.K.Aa.]

fitler on the ruff... fixing typo

Comment 3

[Håkan Waara]

This is really bad. I'd say severity: critical.

Comment 4

[Navin Gupta]

investigating...

Comment 5

[Navin Gupta]

i have a debug build 2 days old and it WFM.

Comment 6

[Navin Gupta]

ok, something bad is happening. Any of the following should be OR
and All of the following should be AND and that is not the case. 

Comment 7

[Navin Gupta]

fix in hand. patch coming up...

Comment 8

[Navin Gupta]

Attachment: proposed fix

Comment 9

[Navin Gupta]

The fix is to assign the searchTerm here. 

Comment 10

[(not reading, please use [e-mail] instead)]

Comment on attachment 50330 [details] [diff] [review]
proposed fix

r=sspitzer

Comment 11

[Navin Gupta]

cc bienvenu for sr.

Comment 12

[David :Bienvenu]

Comment on attachment 50330 [details] [diff] [review]
proposed fix

is this a regression from our code, or did something external change?

Comment 13

[Navin Gupta]

I think this bug has been there for a while (based on CVS blame). 
On Edit if you have "AND" in your filter condition it will still select
the radio button - Any of the following. now this is fixed. 

Comment 14

[Navin Gupta]

fixed on trunk

Comment 15

[Scott MacGregor]

sounds like a stop ship bug to me. Laurel, can you try it out in todays trunk
builds? If it checks out, I'll take it to PDT at 3pm today.

Comment 16

[laurel]

OK using sep24 commercial trunk build win98. 

Comment 17

[laurel]

OK with sep24 trunk build linux rh6.2

Comment 18

[laurel]

OK with sep24 trunk commercial build Mac OS 9.1

Comment 19

[laurel]

Minor detail, see bug 101421, I believe caused by this fix. 

Comment 20

[Jaime Rodriguez, Jr.]

check it in - PDT+

Comment 21

[Navin Gupta]

fixed on branch

Comment 22

[laurel]

OK using sep26 commercial 0.9.4 branch: win98, mac OS 9.1, linux rh6.2, mac OS X

Comment 23

[Navin Gupta]

*** Bug 102228 has been marked as a duplicate of this bug. ***