Closed Bug 1009853 Opened 7 years ago Closed 7 years ago

Compile error: TopSitesCursorWrapper does not override abstract method getNotificationUri() in Cursor

Categories

(Firefox for Android Graveyard :: Awesomescreen, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 32

People

(Reporter: jchen, Assigned: lucasr)

References

Details

Attachments

(1 file)

When using 4.4 SDK (API level 19),

> /home/nchen/gecko-dev/mobile/android/base/db/TopSitesCursorWrapper.java:28: error: TopSitesCursorWrapper is not abstract and does not override abstract method getNotificationUri() in Cursor
> public class TopSitesCursorWrapper implements Cursor {
>        ^
Comment on attachment 8422359 [details] [diff] [review]
Override getNotificationUri() in TopSitesCursorWrapper (r=mfinkle)

Just enough to build on >= 19.
Attachment #8422359 - Flags: review?(mark.finkle)
Comment on attachment 8422359 [details] [diff] [review]
Override getNotificationUri() in TopSitesCursorWrapper (r=mfinkle)

Do you need the "@Override" annotation? I did not think so, but I didn't know what our convention was.
Attachment #8422359 - Flags: review?(mark.finkle) → review+
(In reply to Mark Finkle (:mfinkle) from comment #3)
> Comment on attachment 8422359 [details] [diff] [review]
> Override getNotificationUri() in TopSitesCursorWrapper (r=mfinkle)
> 
> Do you need the "@Override" annotation? I did not think so, but I didn't
> know what our convention was.

It won't built on pre-19 if I add the @Override annotation, this is why I didn't add it.
https://hg.mozilla.org/integration/fx-team/rev/fa6489a53b49
Assignee: nobody → lucasr.at.mozilla
Status: NEW → ASSIGNED
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/69e3f129484a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 32
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.