1009853 - Compile error: TopSitesCursorWrapper does not override abstract method getNotificationUri() in Cursor

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

When using 4.4 SDK (API level 19),

> /home/nchen/gecko-dev/mobile/android/base/db/TopSitesCursorWrapper.java:28: error: TopSitesCursorWrapper is not abstract and does not override abstract method getNotificationUri() in Cursor
> public class TopSitesCursorWrapper implements Cursor {
>        ^

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Override getNotificationUri() in TopSitesCursorWrapper (r=mfinkle)

Comment 2

[Lucas Rocha (:lucasr)]

Comment on attachment 8422359 [details] [diff] [review]
Override getNotificationUri() in TopSitesCursorWrapper (r=mfinkle)

Just enough to build on >= 19.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8422359 [details] [diff] [review]
Override getNotificationUri() in TopSitesCursorWrapper (r=mfinkle)

Do you need the "@Override" annotation? I did not think so, but I didn't know what our convention was.

Comment 4

[Lucas Rocha (:lucasr)]

(In reply to Mark Finkle (:mfinkle) from comment #3)
> Comment on attachment 8422359 [details] [diff] [review]
> Override getNotificationUri() in TopSitesCursorWrapper (r=mfinkle)
> 
> Do you need the "@Override" annotation? I did not think so, but I didn't
> know what our convention was.

It won't built on pre-19 if I add the @Override annotation, this is why I didn't add it.

Comment 5

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/fa6489a53b49

Comment 6

[Nick Alexander :nalexander [he/him]]

Gah, wrong URL:

https://hg.mozilla.org/integration/fx-team/rev/69e3f129484a

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/69e3f129484a