100993 - Update nsIHistoryEntry and nsIHistory...

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Chak Nanga]

nsIHistoryEntry and nsIHistory are currently marked as FROZEN.

They need to be updated to bring them in line with the interface freeze
guidelines at http://www.mozilla.org/projects/embedding/EmbedInterfaceFreeze.html

The same document also gives the issues to be addressed for these particular
interfaces, which are:

nsISHistory:
  * Remove #include for nsIFactory
  * Change #includes to forward declarations for nsIHistoryEntry and
nsIHistoryListener


nsIHistoryEntry:
  * Change the #include of nsIURI.idl into a forward declaration

Comment 1

[Radha on family leave (not reading bugmail)]

Attachment: Initial patch

Comment 2

[Radha on family leave (not reading bugmail)]

Attachment: Updated patch

Comment 3

[Chak Nanga]

Should we be using "PR_TRUE" and "PR_FALSE" in the comment section for the
following attribute[It currently uses "true"/"false" as the return value]

>>>> readonly attribute boolean isSubFrame;

Other than that r=chak
 

Comment 4

[Alec Flett]

Comment on attachment 51301 [details] [diff] [review]
Updated patch

sr=alecf

Comment 5

[Alec Flett]

in IDL, it's more appropriate to refer to 'true' vs 'false' rather than PR_TRUE
vs. PR_FALSE (which are more NSPR concepts than IDL)

Comment 6

[Radha on family leave (not reading bugmail)]

Fix checked in. 

Comment 7

[David Epstein]

verified against mozilla 0.9.4+ Gecko 20011001:
In nsISHistory.idl:
* #include of nsIFactory was removed
* #includes were changed to forward declations ("interface xxx") for
nsIHistoryEntry and nsIHistoryListener.
In nsIHistoryEntry.idl:
* changed #include to forward declaration of nsIURI.idl.
In nsSHistory.cpp
* code added to RemoveSHistoryListener()

#includes added to various header files.

Comment 8

[Blake Ross]

Why was this frozen with PurgeHistory() (as opposed to purgeHistory())?