1009968 - IonMonkey: Implement Lsh Recover Instruction

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Nicolas B. Pierron [:nbp]]

Implement RBitLsh in js/src/jit/Recover.cpp.
See Bug 1003801 comment 0 for explanation.

Comment 1

[Julien Levesy]

Hi Nicolas. 
I'm interested in working on this.

Comment 2

[Julien Levesy]

Attachment: 1009968 Implemented RBitLsh recover operation

Here's a first attempt, with tests on number and object cases.
I ran suite locally. Everything is green on my setup.

Thanks for review ! :)

Comment 3

[Nicolas B. Pierron [:nbp]]

Comment on attachment 8423357 [details] [diff] [review]
1009968 Implemented RBitLsh recover operation

Review of attachment 8423357 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/Recover.h
@@ +19,5 @@
>  #define RECOVER_OPCODE_LIST(_)                  \
>      _(ResumePoint)                              \
>      _(BitNot)                                   \
>      _(BitOr)                                    \
> +    _(BitLsh)                                   \

Sorry, my mistake, this is Lsh, and not BitLsh, as the MIR Instruction name.

Comment 4

[Julien Levesy]

Attachment: 1009968 Implemented RLsh recover operation

No problem, here's an update with full rename.
Thanks :)

Comment 5

[Nicolas B. Pierron [:nbp]]

Comment on attachment 8423690 [details] [diff] [review]
1009968 Implemented RLsh recover operation

Review of attachment 8423690 [details] [diff] [review]:
-----------------------------------------------------------------

This patch is good, but

Your patch is based on an out-dated version of mozilla-central, rebase your changes and resolve the merge conflicts, if any.
Follow the order defined in Bug 1003801 comment 0, such as we have consistency across all files.

Comment 6

[Julien Levesy]

Attachment: 1009968 Implemented RLsh recover operation

Here it is, rebased and reorganized :)

Comment 7

[Nicolas B. Pierron [:nbp]]

https://tbpl.mozilla.org/?tree=Try&rev=be3bcda83ef7

Comment 8

[Nicolas B. Pierron [:nbp]]

I've pushed the patch to mozilla-inbound:
[hg]   https://hg.mozilla.org/integration/mozilla-inbound/rev/ca15242af3a3
[tbpl] https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=ca15242af3a3

Note that I had to modify the title of the patch to follow the commit guideline[1].

[1] https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Committing_Rules_and_Responsibilities

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ca15242af3a3