Closed Bug 1009968 Opened 6 years ago Closed 6 years ago

IonMonkey: Implement Lsh Recover Instruction

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: nbp, Assigned: jlevesy)

References

(Blocks 1 open bug)

Details

(Whiteboard: [good first bug][mentor=nbp][lang=c++])

Attachments

(1 file, 2 obsolete files)

Implement RBitLsh in js/src/jit/Recover.cpp.
See Bug 1003801 comment 0 for explanation.
Hi Nicolas. 
I'm interested in working on this.
Here's a first attempt, with tests on number and object cases.
I ran suite locally. Everything is green on my setup.

Thanks for review ! :)
Attachment #8423357 - Flags: review?(nicolas.b.pierron)
Assignee: nobody → jlevesy
Comment on attachment 8423357 [details] [diff] [review]
1009968 Implemented RBitLsh recover operation

Review of attachment 8423357 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/Recover.h
@@ +19,5 @@
>  #define RECOVER_OPCODE_LIST(_)                  \
>      _(ResumePoint)                              \
>      _(BitNot)                                   \
>      _(BitOr)                                    \
> +    _(BitLsh)                                   \

Sorry, my mistake, this is Lsh, and not BitLsh, as the MIR Instruction name.
Attachment #8423357 - Flags: review?(nicolas.b.pierron) → feedback+
No problem, here's an update with full rename.
Thanks :)
Attachment #8423357 - Attachment is obsolete: true
Attachment #8423690 - Flags: review?(nicolas.b.pierron)
Comment on attachment 8423690 [details] [diff] [review]
1009968 Implemented RLsh recover operation

Review of attachment 8423690 [details] [diff] [review]:
-----------------------------------------------------------------

This patch is good, but

Your patch is based on an out-dated version of mozilla-central, rebase your changes and resolve the merge conflicts, if any.
Follow the order defined in Bug 1003801 comment 0, such as we have consistency across all files.
Attachment #8423690 - Flags: review?(nicolas.b.pierron) → feedback+
Here it is, rebased and reorganized :)
Attachment #8423690 - Attachment is obsolete: true
Attachment #8427641 - Flags: review?(nicolas.b.pierron)
Attachment #8427641 - Flags: review?(nicolas.b.pierron) → review+
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/ca15242af3a3
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.