Closed
Bug 1010014
Opened 10 years ago
Closed 10 years ago
[Build System] homescreen.manifestURL should be customizable.
Categories
(Firefox OS Graveyard :: Gaia::Build, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: GaryChen, Assigned: GaryChen)
References
Details
Attachments
(1 file)
We have 3 homescreen APPs in GAIA code base and homescreen APP may expose to privileged in the next phase. We need a way to customize 'default' homescreen APP for first launch.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → gchen
Assignee | ||
Comment 1•10 years ago
|
||
Hi Yuren, I create a pseudo key -- 'homescreen.appName' as a customization entry key. The function |setHomescreenURL| for composing |homescreen.manifestURL|. Please give me some feedback with this patch or welcome to discuss in person. I will add more test case after we confirm this patch is on the right way. Thanks.
Attachment #8422260 -
Flags: feedback?(yurenju.mozilla)
Comment 2•10 years ago
|
||
Comment on attachment 8422260 [details] [review] pull request: https://github.com/mozilla-b2g/gaia/pull/19227 overall looks good, but please raise an exception if the homescreen app isn't in GAIA_APPDIRS.
Attachment #8422260 -
Flags: feedback?(yurenju.mozilla) → feedback+
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8422260 [details] [review] pull request: https://github.com/mozilla-b2g/gaia/pull/19227 Hi Yuren, I found the redundant variable in https://github.com/mozilla-b2g/gaia/pull/19227/files#diff-b67911656ef5d18c4ae36cb6741b7965L465. So I remove it and I add more test in this patch. Please help to review this patch again. Thanks.
Attachment #8422260 -
Flags: review?(yurenju.mozilla)
Comment 4•10 years ago
|
||
Comment on attachment 8422260 [details] [review] pull request: https://github.com/mozilla-b2g/gaia/pull/19227 r=yurenju if issues on github are addressed.
Attachment #8422260 -
Flags: review?(yurenju.mozilla) → review+
Assignee | ||
Comment 5•10 years ago
|
||
landed in master: https://github.com/mpizza/gaia/commit/6b2c47438fb02c76310f07600d4d7e5d808f482e travis got green: https://travis-ci.org/mozilla-b2g/gaia/builds/25774171
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•