Closed Bug 1010053 Opened 10 years ago Closed 10 years ago

Disable try_gcc45 hook

Categories

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Product:
Developer Services
Component:
Mercurial: hg.mozilla.org
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: glandium, Unassigned)

References

Details

The hook was added in bug 559964 when we switched to gcc 4.5 on try, and changesets before 3a38a70b0e12 couldn't build. They still can't build on try, but they're also 3 years old, and someone pushing something a 3 years old changeset to try can fairly expect something to fail.
Note: this was commented out on hgssh1 during a debugging session tonigh. I don't believe there's a puppet config which will restore the hook, but this bug is to document the removal, and make sure the hook stays gone.
Blocks: 1001735
Hooks aren't controlled by puppet, so no worries there.
no followup needed to ensure change sticks, we're done here
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Actually, one more bit of cleanup to do:

glandium: any reason NOT to hg rm this hook from the repo? I can do that, just need an r? on doing so.
Status: RESOLVED → REOPENED
Flags: needinfo?(mh+mozilla)
Resolution: FIXED → ---
You can happily remove it.
Flags: needinfo?(mh+mozilla)
removed in:
 http://hg.mozilla.org/hgcustom/hghooks/rev/83912e7844d4
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Product: Release Engineering → Developer Services
You need to log in before you can comment on or make changes to this bug.